From dbf46b4e0ba777c14dcfb37a9df6093e1b595bb9 Mon Sep 17 00:00:00 2001 From: James George Date: Thu, 26 Dec 2019 12:15:14 +0530 Subject: [PATCH 1/2] refactor: use includes --- lib/rules/order-in-components.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/rules/order-in-components.js b/lib/rules/order-in-components.js index 5f2c4ecd8..a6ead638e 100644 --- a/lib/rules/order-in-components.js +++ b/lib/rules/order-in-components.js @@ -118,9 +118,9 @@ function isNotSideEffectsNode (node, visitorKeys) { node.type !== 'Property' && node.type !== 'ObjectExpression' && node.type !== 'ArrayExpression' && - (node.type !== 'UnaryExpression' || ['!', '~', '+', '-', 'typeof'].indexOf(node.operator) < 0) && - (node.type !== 'BinaryExpression' || ALL_BINARY_OPERATORS.indexOf(node.operator) < 0) && - (node.type !== 'LogicalExpression' || LOGICAL_OPERATORS.indexOf(node.operator) < 0) && + (node.type !== 'UnaryExpression' || !['!', '~', '+', '-', 'typeof'].includes(node.operator)) && + (node.type !== 'BinaryExpression' || !ALL_BINARY_OPERATORS.includes(node.operator)) && + (node.type !== 'LogicalExpression' || !LOGICAL_OPERATORS.indexOf(node.operator)) && node.type !== 'MemberExpression' && node.type !== 'ConditionalExpression' && // es2015 From ebf7b582d9a2005bc053bbafd1822c09b2f2b1e0 Mon Sep 17 00:00:00 2001 From: James George Date: Thu, 26 Dec 2019 12:18:27 +0530 Subject: [PATCH 2/2] fix: typo --- lib/rules/order-in-components.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rules/order-in-components.js b/lib/rules/order-in-components.js index a6ead638e..c873e8044 100644 --- a/lib/rules/order-in-components.js +++ b/lib/rules/order-in-components.js @@ -120,7 +120,7 @@ function isNotSideEffectsNode (node, visitorKeys) { node.type !== 'ArrayExpression' && (node.type !== 'UnaryExpression' || !['!', '~', '+', '-', 'typeof'].includes(node.operator)) && (node.type !== 'BinaryExpression' || !ALL_BINARY_OPERATORS.includes(node.operator)) && - (node.type !== 'LogicalExpression' || !LOGICAL_OPERATORS.indexOf(node.operator)) && + (node.type !== 'LogicalExpression' || !LOGICAL_OPERATORS.includes(node.operator)) && node.type !== 'MemberExpression' && node.type !== 'ConditionalExpression' && // es2015