add types to vue/no-potential-component-option-typo

Author: ota-meshi

lib/rules/no-potential-component-option-typo.js

@@ -2,7 +2,6 @@
  * @fileoverview detect if there is a potential typo in your component property
  * @author IWANABETHATGUY
  */
-// @ts-nocheck
 'use strict'
 
 const utils = require('../utils')
@@ -53,46 +52,60 @@ module.exports = {
   create(context) {
     const option = context.options[0] || {}
     const custom = option.custom || []
+    /** @type {('all' | 'vue' | 'vue-router' | 'nuxt')[]} */
     const presets = option.presets || ['vue']
     const threshold = option.threshold || 1
-    let candidateOptions
-    if (presets.includes('all')) {
-      candidateOptions = Object.keys(vueComponentOptions).reduce((pre, cur) => {
-        return [...pre, ...vueComponentOptions[cur]]
-      }, [])
-    } else {
-      candidateOptions = presets.reduce((pre, cur) => {
-        return [...pre, ...vueComponentOptions[cur]]
-      }, [])
+    /** @type {Set<string>} */
+    const candidateOptionSet = new Set(custom)
+    for (const preset of presets) {
+      if (preset === 'all') {
+        for (const opts of Object.values(vueComponentOptions)) {
+          for (const opt of opts) {
+            candidateOptionSet.add(opt)
+          }
+        }
+      } else {
+        for (const opt of vueComponentOptions[preset]) {
+          candidateOptionSet.add(opt)
+        }
+      }
     }
-    const candidateOptionSet = new Set([...candidateOptions, ...custom])
     const candidateOptionList = [...candidateOptionSet]
     if (!candidateOptionList.length) {
       return {}
     }
     return utils.executeOnVue(context, (obj) => {
-      const componentInstanceOptions = obj.properties.filter(
-        (p) => p.type === 'Property' && p.key.type === 'Identifier'
-      )
+      const componentInstanceOptions = obj.properties
+        .map((p) => {
+          if (p.type === 'Property') {
+            const name = utils.getStaticPropertyName(p)
+            if (name != null) {
+              return {
+                name,
+                key: p.key
+              }
+            }
+          }
+          return null
+        })
+        .filter(utils.isDef)
+
       if (!componentInstanceOptions.length) {
-        return {}
+        return
       }
       componentInstanceOptions.forEach((option) => {
         const id = option.key
-        const name = id.name
+        const name = option.name
         if (candidateOptionSet.has(name)) {
           return
         }
         const potentialTypoList = candidateOptionList
           .map((o) => ({ option: o, distance: utils.editDistance(o, name) }))
-          .filter(
-            ({ distance, option }) => distance <= threshold && distance > 0
-          )
+          .filter(({ distance }) => distance <= threshold && distance > 0)
           .sort((a, b) => a.distance - b.distance)
         if (potentialTypoList.length) {
           context.report({
             node: id,
-            loc: id.loc,
             message: `'{{name}}' may be a typo, which is similar to option [{{option}}].`,
             data: {
               name,