Skip to content

fix: instance properties example #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2020

Conversation

cexbrayat
Copy link
Member

@cexbrayat cexbrayat commented Jul 13, 2020

While reading through the docs, I spotted an example that needed to be fixed

(PS: sorry for the initial PR title and description, Github was throwing 500 errors and still managed to create an unsaved PR :) )

@cexbrayat cexbrayat changed the title # Do not modify or remove the line above. # Everything below it will be ignored. fix: instance properties example Jul 13, 2020
Copy link
Member

@NataliaTepluhina NataliaTepluhina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thank you @cexbrayat for spotting and fixing it 🙇

@NataliaTepluhina NataliaTepluhina merged commit 9d67355 into master Jul 13, 2020
@cexbrayat cexbrayat deleted the fix/instance-property-example branch July 14, 2020 10:09
TalexDreamSoul pushed a commit to Talexs/docs that referenced this pull request Apr 17, 2022
* fix: deleted duplicate words, 上上 -> 上

* fix: revise the paragraph to better understand

* fix: correct punctuation

* Update src/guide/extras/web-components.md

* fix: fixed the translation of effect

* fix: Keep the translation consistent

* Update src/guide/extras/reactivity-in-depth.md

Co-authored-by: wxsm <[email protected]>

* Update src/guide/extras/reactivity-in-depth.md

Co-authored-by: wxsm <[email protected]>

* fix: translated the omissive section

* fix: translated 'see also...'

* fix: Keep the format consistent

* Update src/guide/essentials/template-refs.md

Co-authored-by: wxsm <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants