[Easy] Fix env type check errors from VLLM_DEBUG_LOG_API_SERVER_RESPONSE #26742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jialin Ouyang <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly resolves a type checking error by adding the type definition for the VLLM_DEBUG_LOG_API_SERVER_RESPONSE environment variable within the TYPE_CHECKING block. The change is accurate, consistent with its runtime implementation, and effectively fixes the reported issue. The code is clean and I have no further recommendations.
Collaborator
Author
|
CC @terrytangyuan who firstly introduced the environment variable a while back ago. |
5 tasks
mgoin
added
bug
mgoin
approved these changes
Oct 13, 2025
1994
pushed a commit
to 1994/vllm
that referenced
this pull request
Oct 14, 2025
…NSE (vllm-project#26742) Signed-off-by: Jialin Ouyang <[email protected]> Signed-off-by: 1994 <[email protected]>
Dhruvilbhatt
pushed a commit
to Dhruvilbhatt/vllm
that referenced
this pull request
Oct 14, 2025
…NSE (vllm-project#26742) Signed-off-by: Jialin Ouyang <[email protected]> Signed-off-by: Dhruvil Bhatt <[email protected]>
bbartels
pushed a commit
to bbartels/vllm
that referenced
this pull request
Oct 16, 2025
…NSE (vllm-project#26742) Signed-off-by: Jialin Ouyang <[email protected]> Signed-off-by: bbartels <[email protected]>
lywa1998
pushed a commit
to lywa1998/vllm
that referenced
this pull request
Oct 20, 2025
…NSE (vllm-project#26742) Signed-off-by: Jialin Ouyang <[email protected]>
alhridoy
pushed a commit
to alhridoy/vllm
that referenced
this pull request
Oct 24, 2025
…NSE (vllm-project#26742) Signed-off-by: Jialin Ouyang <[email protected]>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 24, 2025
…NSE (vllm-project#26742) Signed-off-by: Jialin Ouyang <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 24, 2025
…NSE (vllm-project#26742) Signed-off-by: Jialin Ouyang <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
0xrushi
pushed a commit
to 0xrushi/vllm
that referenced
this pull request
Oct 26, 2025
…NSE (vllm-project#26742) Signed-off-by: Jialin Ouyang <[email protected]> Signed-off-by: 0xrushi <[email protected]>
0xrushi
pushed a commit
to 0xrushi/vllm
that referenced
this pull request
Oct 26, 2025
…NSE (vllm-project#26742) Signed-off-by: Jialin Ouyang <[email protected]> Signed-off-by: 0xrushi <[email protected]>
rtourgeman
pushed a commit
to rtourgeman/vllm
that referenced
this pull request
Nov 10, 2025
…NSE (vllm-project#26742) Signed-off-by: Jialin Ouyang <[email protected]>
Zhathw
pushed a commit
to Zhathw/vllm
that referenced
this pull request
Nov 12, 2025
…NSE (vllm-project#26742) Signed-off-by: Jialin Ouyang <[email protected]>
devpatelio
pushed a commit
to SumanthRH/vllm
that referenced
this pull request
Nov 29, 2025
…NSE (vllm-project#26742) Signed-off-by: Jialin Ouyang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix type check errors due to type check variable VLLM_DEBUG_LOG_API_SERVER_RESPONSE undefined.
We ran into this error in #26146 which is not directly related.
Test Plan
N/A
Test Result
N/A
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.