-
-
Notifications
You must be signed in to change notification settings - Fork 11.8k
[CI Perf] Prune tests in tests/kernels/moe/
#22939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: mgoin <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to improve CI performance by pruning the test suite for MoE kernels. The changes effectively reduce the number of test combinations by limiting the values in pytest.mark.parametrize and replacing Cartesian products of parameters with a curated list of test cases.
However, a recurring pattern in this pruning is the removal of torch.float16 and torch.float32 data types from several tests. While this reduces test execution time, it also significantly reduces test coverage for these supported dtypes. This is risky as it could mask precision-related regressions, especially on hardware where float16 is common. I have added comments highlighting these specific cases, recommending to re-introduce some of the removed dtypes to maintain a safer level of test coverage.
yewentao256
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks for the work!
Signed-off-by: mgoin <[email protected]>
Signed-off-by: mgoin <[email protected]>
Signed-off-by: mgoin <[email protected]> Signed-off-by: Duncan Moss <[email protected]>
Signed-off-by: mgoin <[email protected]>
Signed-off-by: mgoin <[email protected]> Signed-off-by: Xiao Yu <[email protected]>
Signed-off-by: mgoin <[email protected]>
Purpose
Test Plan
Test Result
(Optional) Documentation Update
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.