Skip to content

Conversation

@mgoin
Copy link
Member

@mgoin mgoin commented Aug 14, 2025

Purpose

pytest --collect-only -qq tests/kernels/moe

# main
tests/kernels/moe/test_batched_deepgemm.py: 32
tests/kernels/moe/test_batched_moe.py: 3936
tests/kernels/moe/test_block_fp8.py: 450
tests/kernels/moe/test_block_int8.py: 224
tests/kernels/moe/test_count_expert_num_tokens.py: 853
tests/kernels/moe/test_cutlass_grouped_gemm.py: 6
tests/kernels/moe/test_cutlass_moe.py: 462
tests/kernels/moe/test_deepep_deepgemm_moe.py: 34
tests/kernels/moe/test_deepep_moe.py: 56
tests/kernels/moe/test_deepgemm.py: 12
tests/kernels/moe/test_modular_kernel_combinations.py: 108
tests/kernels/moe/test_moe.py: 9105
tests/kernels/moe/test_moe_align_block_size.py: 1125
tests/kernels/moe/test_moe_permute_unpermute.py: 3456
tests/kernels/moe/test_mxfp4_moe.py: 3
tests/kernels/moe/test_nvfp4_moe.py: 180
tests/kernels/moe/test_pplx_cutlass_moe.py: 32
tests/kernels/moe/test_pplx_moe.py: 986
tests/kernels/moe/test_rocm_aiter_topk.py: 4
tests/kernels/moe/test_silu_mul_fp8_quant_deep_gemm.py: 5
tests/kernels/moe/test_triton_moe_ptpc_fp8.py: 32

# pr
tests/kernels/moe/test_batched_deepgemm.py: 32
tests/kernels/moe/test_batched_moe.py: 1104
tests/kernels/moe/test_block_fp8.py: 450
tests/kernels/moe/test_block_int8.py: 224
tests/kernels/moe/test_count_expert_num_tokens.py: 146
tests/kernels/moe/test_cutlass_grouped_gemm.py: 6
tests/kernels/moe/test_cutlass_moe.py: 462
tests/kernels/moe/test_deepep_deepgemm_moe.py: 34
tests/kernels/moe/test_deepep_moe.py: 56
tests/kernels/moe/test_deepgemm.py: 12
tests/kernels/moe/test_modular_kernel_combinations.py: 108
tests/kernels/moe/test_moe.py: 3701
tests/kernels/moe/test_moe_align_block_size.py: 325
tests/kernels/moe/test_moe_permute_unpermute.py: 432
tests/kernels/moe/test_mxfp4_moe.py: 3
tests/kernels/moe/test_nvfp4_moe.py: 180
tests/kernels/moe/test_pplx_cutlass_moe.py: 32
tests/kernels/moe/test_pplx_moe.py: 800
tests/kernels/moe/test_rocm_aiter_topk.py: 4
tests/kernels/moe/test_silu_mul_fp8_quant_deep_gemm.py: 5
tests/kernels/moe/test_triton_moe_ptpc_fp8.py: 32

Test Plan

Test Result

(Optional) Documentation Update


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to improve CI performance by pruning the test suite for MoE kernels. The changes effectively reduce the number of test combinations by limiting the values in pytest.mark.parametrize and replacing Cartesian products of parameters with a curated list of test cases.

However, a recurring pattern in this pruning is the removal of torch.float16 and torch.float32 data types from several tests. While this reduces test execution time, it also significantly reduces test coverage for these supported dtypes. This is risky as it could mask precision-related regressions, especially on hardware where float16 is common. I have added comments highlighting these specific cases, recommending to re-introduce some of the removed dtypes to maintain a safer level of test coverage.

@mgoin mgoin added ready ONLY add when PR is ready to merge/full CI is needed ci/build labels Aug 14, 2025
Copy link
Member

@yewentao256 yewentao256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for the work!

@mgoin mgoin merged commit d2b0e97 into vllm-project:main Aug 15, 2025
30 checks passed
@mgoin mgoin deleted the prune-kernel-moe-tests branch August 15, 2025 03:33
yiliu30 pushed a commit to yiliu30/vllm-fork that referenced this pull request Aug 19, 2025
divakar-amd pushed a commit to divakar-amd/vllm_upstream that referenced this pull request Aug 20, 2025
djmmoss pushed a commit to djmmoss/vllm that referenced this pull request Aug 21, 2025
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants