Skip to content

[Bugfix][CI] Inherit codespell settings from pyproject.toml in the pre-commit-config #13237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 14, 2025
Merged

[Bugfix][CI] Inherit codespell settings from pyproject.toml in the pre-commit-config #13237

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
21cd610
Inherit codespell settings from pyproject.toml in precommit hook
tlrmchlsmth Feb 13, 2025
2e8c6be
add exclude back in
tlrmchlsmth Feb 13, 2025
6d18b0a
reviews
tlrmchlsmth Feb 13, 2025
ab4689e
try changing paths
tlrmchlsmth Feb 13, 2025
17e3035
this works
tlrmchlsmth Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ repos:
rev: v2.4.0
hooks:
- id: codespell
additional_dependencies: ['tomli']
args: ['--toml', 'pyproject.toml']
exclude: 'benchmarks/sonnet.txt|(build|tests/(lora/data|models/fixtures|prompts))/.*|vllm/third_party/.*'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we delete this line now if pre-commit is getting this config from pyproject.toml?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried that initially but it was failing here: https://github.com/vllm-project/vllm/actions/runs/13316648035/job/37192184214

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, should be good now 👍

- repo: https://github.com/PyCQA/isort
rev: 5.13.2
Expand Down
1 change: 1 addition & 0 deletions requirements-lint.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
# formatting
tomli
pre-commit==4.0.1
Loading