Skip to content

[ROCm] Using a more precise memory profiling #12624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 11, 2025
Merged

[ROCm] Using a more precise memory profiling #12624

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8388cf1
Using a more precise profiling on ROCm to properly account for weight…
gshtras Jan 30, 2025
74f7daa
Passing device to the torch function
gshtras Feb 6, 2025
a4a98b0
Merge remote-tracking branch 'origin/main' into mem_profile_upstream
gshtras Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vllm/platforms/rocm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,4 +164,4 @@ def get_current_memory_usage(cls,
device: Optional[torch.types.Device] = None
) -> float:
torch.cuda.reset_peak_memory_stats(device)
return torch.cuda.max_memory_allocated(device)
return torch.cuda.mem_get_info()[1] - torch.cuda.mem_get_info()[0]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pass device to torch.cuda.mem_get_info() ?