From c75b616b7ccbb7df5f17581fcf6ec84eec7ecdaa Mon Sep 17 00:00:00 2001 From: Hiroshi Ogawa Date: Fri, 11 Jul 2025 12:10:44 +0900 Subject: [PATCH 1/4] test(rsc): disable `TEST_ISOLATED` on windows --- .github/workflows/ci-rsc.yml | 2 +- packages/plugin-rsc/e2e/basic.test.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci-rsc.yml b/.github/workflows/ci-rsc.yml index b21b0d0b3..4a2bc31a7 100644 --- a/.github/workflows/ci-rsc.yml +++ b/.github/workflows/ci-rsc.yml @@ -63,7 +63,7 @@ jobs: - run: pnpm -C packages/plugin-rsc exec playwright install ${{ matrix.browser }} - run: pnpm -C packages/plugin-rsc test-e2e-ci --project=${{ matrix.browser }} env: - TEST_ISOLATED: true + TEST_ISOLATED: ${{ matrix.os === 'windows-latest' && 'false' || 'true' }} - uses: actions/upload-artifact@v4 if: always() with: diff --git a/packages/plugin-rsc/e2e/basic.test.ts b/packages/plugin-rsc/e2e/basic.test.ts index a1ef08495..77066ce42 100644 --- a/packages/plugin-rsc/e2e/basic.test.ts +++ b/packages/plugin-rsc/e2e/basic.test.ts @@ -105,7 +105,7 @@ test.describe('build-react-compiler', () => { test.describe(() => { // disabled by default - if (!process.env.TEST_ISOLATED) return + if (process.env.TEST_ISOLATED !== 'true') return let tmpRoot = '/tmp/test-vite-rsc' test.beforeAll(async () => { From dbb357032c352c91c73a71db52de24c6548a1de6 Mon Sep 17 00:00:00 2001 From: Hiroshi Ogawa Date: Fri, 11 Jul 2025 12:17:31 +0900 Subject: [PATCH 2/4] ci: typo --- .github/workflows/ci-rsc.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci-rsc.yml b/.github/workflows/ci-rsc.yml index 4a2bc31a7..256b1e901 100644 --- a/.github/workflows/ci-rsc.yml +++ b/.github/workflows/ci-rsc.yml @@ -63,7 +63,7 @@ jobs: - run: pnpm -C packages/plugin-rsc exec playwright install ${{ matrix.browser }} - run: pnpm -C packages/plugin-rsc test-e2e-ci --project=${{ matrix.browser }} env: - TEST_ISOLATED: ${{ matrix.os === 'windows-latest' && 'false' || 'true' }} + TEST_ISOLATED: ${{ matrix.os == 'windows-latest' && 'false' || 'true' }} - uses: actions/upload-artifact@v4 if: always() with: From 4ce9a018bc15eeec69cd6a40bdd01adde44c790e Mon Sep 17 00:00:00 2001 From: Hiroshi Ogawa Date: Fri, 11 Jul 2025 12:17:52 +0900 Subject: [PATCH 3/4] ci: typo --- .github/workflows/ci-rsc.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci-rsc.yml b/.github/workflows/ci-rsc.yml index 256b1e901..6c46f0672 100644 --- a/.github/workflows/ci-rsc.yml +++ b/.github/workflows/ci-rsc.yml @@ -63,7 +63,7 @@ jobs: - run: pnpm -C packages/plugin-rsc exec playwright install ${{ matrix.browser }} - run: pnpm -C packages/plugin-rsc test-e2e-ci --project=${{ matrix.browser }} env: - TEST_ISOLATED: ${{ matrix.os == 'windows-latest' && 'false' || 'true' }} + TEST_ISOLATED: ${{ matrix.os == 'windows-latest' }} - uses: actions/upload-artifact@v4 if: always() with: From e2a1f70b0ae762bedb6485609d1f584bead6db63 Mon Sep 17 00:00:00 2001 From: Hiroshi Ogawa Date: Fri, 11 Jul 2025 12:20:43 +0900 Subject: [PATCH 4/4] ci: negate --- .github/workflows/ci-rsc.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci-rsc.yml b/.github/workflows/ci-rsc.yml index 6c46f0672..19107c4da 100644 --- a/.github/workflows/ci-rsc.yml +++ b/.github/workflows/ci-rsc.yml @@ -63,7 +63,7 @@ jobs: - run: pnpm -C packages/plugin-rsc exec playwright install ${{ matrix.browser }} - run: pnpm -C packages/plugin-rsc test-e2e-ci --project=${{ matrix.browser }} env: - TEST_ISOLATED: ${{ matrix.os == 'windows-latest' }} + TEST_ISOLATED: ${{ matrix.os != 'windows-latest' }} - uses: actions/upload-artifact@v4 if: always() with: