Skip to content

Conversation

@lambdalisue
Copy link
Member

Summary

  • Fixes an issue where the first matching was not executed when using the -input= option
  • The root cause was that initialQuery was being set to #previousQuery, which prevented the matching logic from detecting a query change

Changes

  • Set #previousQuery to undefined on initialization instead of initialQuery
  • Added comment explaining why this is necessary for the -input= option to work correctly

Test plan

  • Verify that providing -input= option triggers initial matching
  • Verify that normal operation without -input= still works as expected

Notes

Recreated from main branch to ensure clean CI runs.

The previous implementation set initialQuery to #previousQuery, which
prevented the first matching from executing when an initial query was
provided via the -input= option. This fix ensures the first matching
always runs by keeping #previousQuery undefined on initialization.
@codecov
Copy link

codecov bot commented Oct 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.84%. Comparing base (abfe3b7) to head (cd1fd63).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #47   +/-   ##
=======================================
  Coverage   83.84%   83.84%           
=======================================
  Files          32       32           
  Lines        2024     2024           
  Branches      214      214           
=======================================
  Hits         1697     1697           
  Misses        324      324           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lambdalisue lambdalisue merged commit c2c3f64 into main Oct 18, 2025
6 checks passed
@lambdalisue lambdalisue deleted the fix/initial-query-matching-v2 branch October 18, 2025 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants