Skip to content

Conversation

@mityu
Copy link
Contributor

@mityu mityu commented Feb 16, 2025

Fix the cursor line is not highlighted when neither line and screenline are not set to cursorlineopt.
This PR makes the window-local option cursorlineopt surely have line value for the fall.vim windows.

  • before:
image.png
  • after:
image

Reproduce Steps

  • Prepare this vimrc.vim
set nocompatible

" Please modify these runtimepath value
set runtimepath^=~/.cache/vim/pack/minpac/opt/denops.vim/
set runtimepath^=~/.cache/vim/pack/minpac/opt/fall.vim/

set cursorlineopt=number
let g:fall_custom_path = '/tmp/notfound.vim'
  • Run vim by vim -u vimrc.vim
  • Start fall.vim by :Fall help
  • Check the highlights for the cursor line

Environment

  • macOS Sequoia
  • wezterm 20240203-110809-5046fc22
  • Vim 9.1.1113
  • deno
deno 2.1.10 (stable, release, aarch64-apple-darwin)
v8 13.0.245.12-rusty
typescript 5.6.2

@codecov
Copy link

codecov bot commented Feb 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.72%. Comparing base (88c6ec5) to head (daeee0c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #30   +/-   ##
=======================================
  Coverage   80.72%   80.72%           
=======================================
  Files          24       24           
  Lines        1655     1655           
  Branches      163      163           
=======================================
  Hits         1336     1336           
  Misses        316      316           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lambdalisue lambdalisue merged commit 6d491d5 into vim-fall:main Feb 16, 2025
6 checks passed
@lambdalisue
Copy link
Member

Thanks!

@mityu mityu deleted the show-cursorline branch February 16, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants