Skip to content

fix: don't lock base path at grep and rg Curators #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2024
Merged

fix: don't lock base path at grep and rg Curators #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions builtin/curator/grep.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,10 @@
* @returns A Curator that yields search results in the form of `GrepDetail`.
*/
export function grep(options: GrepOptions = {}): Curator<Detail> {
let base: string;
return defineCurator(
async function* (denops, { args, query }, { signal }) {
// Determine the root directory for the grep command
base ??= await getAbsolutePathOf(denops, args[0] ?? ".", signal);
const base = await getAbsolutePathOf(denops, args[0] ?? ".", signal);

Check warning on line 46 in builtin/curator/grep.ts

View check run for this annotation

Codecov / codecov/patch

builtin/curator/grep.ts#L46 

Added line #L46 was not covered by tests

// Configure the `grep` command with the provided query
const cmd = new Deno.Command("grep", {
Expand Down
3 changes: 1 addition & 2 deletions builtin/curator/rg.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,10 @@
* @returns A Curator that yields search results in the form of `RgDetail`.
*/
export function rg(options: RgOptions = {}): Curator<Detail> {
let base: string;
return defineCurator(
async function* (denops, { args, query }, { signal }) {
// Determine the root directory for the rg command
base ??= await getAbsolutePathOf(denops, args[0] ?? ".", signal);
const base = await getAbsolutePathOf(denops, args[0] ?? ".", signal);

Check warning on line 44 in builtin/curator/rg.ts

View check run for this annotation

Codecov / codecov/patch

builtin/curator/rg.ts#L44 

Added line #L44 was not covered by tests

// Configure the `rg` command with the provided query
const cmd = new Deno.Command("rg", {
Expand Down