Update TypeScript and ESLint configs for compatibility (#5)

Author: mcous

.eslintrc.cjs

@@ -3,9 +3,6 @@
 module.exports = {
   root: true,
   extends: ['@viamrobotics/eslint-config'],
-  env: {
-    node: true,
-  },
   parserOptions: {
     project: ['./tsconfig.json', './packages/*/tsconfig.json'],
   },

.gitignore

@@ -1,3 +1,4 @@
 node_modules
 pnpm-publish-summary.json
 *.d.cts
+*.tgz

packages/eslint-config/base.cjs

@@ -70,7 +70,6 @@ module.exports = {
     'no-constructor-return': 'error',
     'no-debugger': 'warn',
     'no-div-regex': 'error',
-    'no-duplicate-imports': 'error',
     'no-else-return': 'error',
     'no-empty-static-block': 'error',
     'no-eval': 'error',
@@ -110,7 +109,6 @@ module.exports = {
     'no-unmodified-loop-condition': 'error',
     'no-unused-expressions': 'error',
     'no-unused-private-class-members': 'error',
-    'no-use-before-define': 'error',
     'no-useless-call': 'error',
     'no-useless-computed-key': 'error',
     'no-useless-concat': 'error',
@@ -154,6 +152,16 @@ module.exports = {
     '@typescript-eslint/return-await': 'error',
     '@typescript-eslint/no-non-null-assertion': 'off',
     '@typescript-eslint/no-unused-vars': ['warn', { argsIgnorePattern: '^_' }],
+    '@typescript-eslint/no-use-before-define': [
+      'warn',
+      {
+        functions: false,
+        classes: false,
+        variables: false,
+        allowNamedExports: true,
+        ignoreTypeReferences: true,
+      },
+    ],
 
     // Extra import rules
     'import/no-absolute-path': 'error',
@@ -178,6 +186,9 @@ module.exports = {
       parserOptions: {
         sourceType: 'script',
       },
+      env: {
+        commonjs: true,
+      },
       rules: {
         '@typescript-eslint/no-var-requires': 'off',
       },

packages/eslint-config/package.json

@@ -3,8 +3,12 @@
   "publishConfig": {
     "access": "public"
   },
-  "version": "0.0.1",
+  "version": "0.0.2",
   "description": "Common ESLint configuration for Viam projects.",
+  "files": [
+    "**/*",
+    "!tsconfig.json"
+  ],
   "types": "./base.d.cts",
   "exports": {
     ".": {

packages/eslint-config/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "@viamrobotics/typescript-config",
+  "extends": "@viamrobotics/typescript-config/base.json",
   "compilerOptions": {
     "types": ["node"],
     "declaration": true,

packages/prettier-config/package.json

@@ -5,6 +5,10 @@
   },
   "version": "0.0.1",
   "description": "Common Prettier configuration for Viam projects.",
+  "files": [
+    "**/*",
+    "!tsconfig.json"
+  ],
   "types": "./base.d.cts",
   "exports": {
     ".": {

packages/prettier-config/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "@viamrobotics/typescript-config",
+  "extends": "@viamrobotics/typescript-config/base.json",
   "compilerOptions": {
     "types": ["node"],
     "declaration": true,

packages/typescript-config/README.md

@@ -16,6 +16,6 @@ Use the [base config](./tsconfig.base.json) for generic TypeScript projects, inc
 ```json
 // tsconfig.json
 {
-  "extends": "@viamrobotics/typescript-config"
+  "extends": "@viamrobotics/typescript-config/base.json"
 }
 ```

packages/typescript-config/tsconfig.base.json renamed to packages/typescript-config/base.json

@@ -3,11 +3,12 @@
   "publishConfig": {
     "access": "public"
   },
-  "version": "0.0.1",
+  "version": "0.0.2",
   "description": "Common TypeScript configuration for Viam projects.",
-  "exports": {
-    ".": "./tsconfig.base.json"
-  },
+  "files": [
+    "**/*",
+    "!tsconfig.json"
+  ],
   "repository": {
     "type": "git",
     "url": "git+https://github.com/viamrobotics/js-config.git",

packages/typescript-config/package.json

@@ -1,5 +1,5 @@
 {
-  "extends": "@viamrobotics/typescript-config",
+  "extends": "@viamrobotics/typescript-config/base.json",
   "compilerOptions": {
     "types": ["node"],
     "noEmit": true