fix: fix remove preselected elements by id #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javier-godoy
requested changes
Aug 21, 2024
Member
javier-godoy
left a comment
javier-godoy
left a comment
There was a problem hiding this comment.
It would be helpful to include a brief description for this change.
Collaborator
Author
@javier-godoy description updated. |
javier-godoy
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update is needed for vaadin-component-factory/vcf-date-range-picker-flow#45.
Method
removePreselectionByIdis supposed to be called when overlay opens. It was failing as the event being trigered when it opens isvaadin-overlay-openinstead ofopened-changed. So the method was not being called when needed. I think this feature was not taken in consideration when overlay updates were done on the big refactor done on the component to be compatible with vaadin 24 https://github.com/vaadin-component-factory/vcf-date-range-picker/pull/39/files.Method
removePreselectionByIdis being called from server-side's methodremovePresetByIdsmentioned in issue vaadin-component-factory/vcf-date-range-picker-flow#45