[UNDERTOW-2638] Proposal for a multi-buffer ChunkedStreamSinkConduit.write implementation #1364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carterkozak
force-pushed
the
ckozak/UNDERTOW-2142-batch-chunk-proposal
branch
from
0106b60 to
de9101d
Compare
carterkozak
commented
Aug 22, 2022
Comment on lines
141
to
151
| // Fall back to one buffer at a time if the total srcs remaining exceeds integer max-value | ||
| // This should be very rare. | ||
| for (int i = offset; i < offset + length; i++) { | ||
| ByteBuffer buf = srcs[i]; | ||
| if (buf.hasRemaining()) { | ||
| return write(buf); | ||
| } | ||
| } | ||
| return 0; |
Contributor
Author
There was a problem hiding this comment.
In this case, we could internally reduce length and potentially dial back the limit on the final buffer, matching the chunkleft>0 case on 170
carterkozak
commented
Aug 22, 2022
| } | ||
|
|
||
| @Override | ||
| public long write(final ByteBuffer[] srcs, final int offset, final int length) throws IOException { |
Contributor
Author
There was a problem hiding this comment.
At the cost of some single-element array allocations, we could delegate the single-buffer implementation to this one, just like sslconduit
carterkozak
force-pushed
the
ckozak/UNDERTOW-2142-batch-chunk-proposal
branch
from
7a85388 to
4a440d1
Compare
fl4via
approved these changes
Oct 15, 2025
fl4via
changed the title
fl4via
force-pushed
the
ckozak/UNDERTOW-2142-batch-chunk-proposal
branch
from
4a440d1 to
4cf5e23
Compare
fl4via
force-pushed
the
ckozak/UNDERTOW-2142-batch-chunk-proposal
branch
from
4cf5e23 to
dae2a96
Compare
fl4via
approved these changes
Oct 15, 2025
| } | ||
|
|
||
| @Override | ||
| public long write(final ByteBuffer[] srcs, final int offset, final int length) throws IOException { |
fl4via
added
waiting CI check
This was referenced Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.redhat.com/browse/UNDERTOW-2638