Data Type: use Property Editor UI label instead over name #20716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the data type workspace to use localized labels from property editor UI manifests. The changes ensure that property editor names are properly localized and prefer the meta.label field over the name field for display purposes.
Key Changes
- Property editor UI names now use
meta.labelas the primary source withnameas fallback - All property editor name displays are wrapped with
localize.string()for proper localization - Consistent pattern applied across data type workspace and modal components
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| data-type-workspace.context.ts | Updated to prefer meta.label over name when setting property editor UI name |
| data-type-details-workspace-property-editor-picker.element.ts | Wrapped property editor UI name with localize.string() for display |
| data-type-picker-flow-modal.element.ts | Updated to use meta.label with fallback chain and wrapped with localize.string() |
...a-type/workspace/views/details/data-type-details-workspace-property-editor-picker.element.ts
Show resolved
Hide resolved
…acceptance test The reason for this is that the property-editor's alias and UI alias are enough to identify the correct property-editor (RTE) for the data-type configuration.
leekelleher
approved these changes
Nov 3, 2025
Member
leekelleher
left a comment
leekelleher
left a comment
There was a problem hiding this comment.
Tested out, looks good to me. 🚀
We had a failing acceptance test for the "Richtext editor" data-type. I've opted to remove the check for the name, as we also checking the property-editor's alias and UI alias, which is enough to verify that the data-type's configuration is the Tiptap property-editor.
nielslyngsoe
deleted the
v17/hotfix/data-type-use-property-editor-ui-label-instead-of-name
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the Property Editor UI Label over the extension name, but still fallback to the name if no label is defined.
Both for the display of the picked property editor and for the Data-Type name generation, when created via the Property-Type Create New Data-Type flow.
As well adding localization of it.