Document/Media Recycle Bin: Add 'Trashed' state to info workspace view #20581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a new 'Trashed' label and tag for documents in the workspace view. Updates localization to include the 'Trashed' term for improved clarity when displaying trashed documents.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds visual indication when a document is in the "Trashed" state within the document workspace info view. The implementation displays a red tag labeled "Trashed" when a document has been moved to the recycle bin.
Key Changes:
- Added "Trashed" localization key to English language file
- Implemented UI rendering for trashed document state with a danger-styled tag
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Umbraco.Web.UI.Client/src/packages/documents/documents/workspace/views/info/document-workspace-view-info.element.ts | Added case handler for TRASHED state to render red danger tag |
| src/Umbraco.Web.UI.Client/src/assets/lang/en.ts | Added 'trashed' localization key |
madsrasmussen
changed the title
madsrasmussen
changed the title
AndyButland
approved these changes
Oct 21, 2025
Contributor
AndyButland
left a comment
AndyButland
left a comment
There was a problem hiding this comment.
The updates in this PR look good @madsrasmussen - I can see the "Trashed" state appearing as expected on the Info panel.
I found a couple of little issues though. Will approve as I don't think they are related, but you may want to look at them in this PR or another.
- If I view a document in the recycle bin and refresh the browser, I see this error pop-up.
- When restoring the location to restore too isn't displayed:
Contributor
Author
|
thanks @AndyButland Both issues have already been reported 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for displaying the "Trashed" state for documents in the UI. The main changes include introducing a new localized label for trashed content and updating the document info view to show a red tag when a document is trashed.