Caching: Fixes regression of the caching of null representations for missing dictionary items (closes #20336 for 16) #20349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssing dictionary items.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a regression in dictionary item caching where null representations for missing dictionary items were not being cached properly. The fix ensures that null values can be cached and retrieved correctly using a special null representation constant.
- Refactors cache item retrieval logic to properly handle null representations
- Adds comprehensive test coverage for dictionary repository caching behavior
- Introduces helper methods to distinguish between actual nulls and cached null representations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Persistence/Repositories/DictionaryRepositoryTest.cs | Adds extensive test coverage for dictionary repository caching scenarios with both existing and non-existing values |
| src/Umbraco.Core/Cache/AppCacheExtensions.cs | Refactors cache retrieval logic to properly handle null representations and distinguish between actual nulls and cached nulls |
1 task
AndyButland
changed the title
|
This pull request has been mentioned on Umbraco community forum. There might be relevant details there: https://forum.umbraco.com/t/website-significantly-slower-since-upgrading-from-v13-to-v16/6049/9 |
kjac
deleted the
v16/bugfix/fix-handling-of-null-representation-in-cache
branch
AndyButland
added a commit
that referenced
this pull request
Oct 2, 2025
…missing dictionary items (closes #20336 for 16) (#20349) * Ports fix to regression of the caching of null representations for missing dictionary items. * Fixed error raised in code review. --------- Co-authored-by: Kenn Jacobsen <[email protected]>
This was referenced Oct 20, 2025
This was referenced Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports #20344 for Umbraco 16.