Data Type: Improve missing property editor and property editor UI feedback #20339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itor or editor UI that could not be found
…ould not be found
nielslyngsoe
approved these changes
Oct 2, 2025
Member
nielslyngsoe
left a comment
nielslyngsoe
left a comment
There was a problem hiding this comment.
Really great — Thanks a lot!
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the user experience when dealing with missing property editors and property editor UIs in Umbraco CMS by providing clearer feedback and validation. The changes include enhanced visibility of missing editors with visual indicators, improved error messages, and prevention of saving data types with missing configurations.
- Refactored missing property editor components to share common functionality through a base class
- Added validation to prevent saving data types with missing property editors/UIs
- Enhanced error messages and visual feedback for missing property editor UIs
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| property-editor-ui-missing.element.ts | Refactored to extend base class and simplified implementation |
| property-editor-ui-missing-ui.element.ts | New component for handling missing property editor UI scenarios |
| property-editor-ui-missing-base.element.ts | New base class containing shared functionality for missing property editor components |
| manifests.ts | Added manifest for new missing UI component and updated existing manifest |
| data-type-details-workspace-view.element.ts | Simplified to use new property editor picker component |
| data-type-details-workspace-property-editor-picker.element.ts | New component with validation for missing property editors/UIs |
| data-type-workspace.context.ts | Added fallback logic for property editor schema alias |
| property.element.ts | Added fallback to missing UI component when property editor UI not found |
| constants.ts | Added constants for missing property editor UI aliases |
| validation.controller.ts | Enhanced error message for missing validation messages |
| lang files | Added localization strings for new error messages |
...a-type/workspace/views/details/data-type-details-workspace-property-editor-picker.element.ts
Show resolved
Hide resolved
...b.UI.Client/src/packages/property-editors/missing/property-editor-ui-missing-base.element.ts
Show resolved
Hide resolved
src/Umbraco.Web.UI.Client/src/packages/core/property/components/property/property.element.ts
Show resolved
Hide resolved
Contributor
Author
|
Converted back to draft as this caused a failing smoke test: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the user experience when dealing with missing property editors and property editor UIs in two key areas:
Data Type Workspace Improvements
Property Editor UI Feedback