-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Localization/UX: Add a new general translation for "Fields" #20259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Localization/UX: Add a new general translation for "Fields" #20259
Conversation
|
Hi there @bjarnef, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new general translation key "fields" (plural) to complement the existing "field" (singular) translation, and updates the Examine Management Dashboard to use the new general translation instead of the examine-specific one.
- Adds "fields" translation key to all language files (en, da, nb, pt, vi)
- Updates Examine searcher table header to use general_fields instead of examineManagement_fields
- Updates Examine fields settings modal headline to use general_fields
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| section-view-examine-searchers.ts | Updates table header to use general_fields translation key |
| examine-fields-settings-modal.element.ts | Updates modal headline to use general_fields translation key |
| en.ts | Adds "fields" translation for English |
| da.ts | Adds "fields" translation for Danish |
| nb.ts | Adds "fields" translation for Norwegian |
| pt.ts | Adds "fields" translation for Portuguese |
| vi.ts | Adds "fields" translation for Vietnamese |
AndyButland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bjarnef - looks good to me when I've run it locally. Have retargeted for 17 as that's the release this will now go in.
Prerequisites
If there's an existing issue for this PR then this fixes #20234
Description
As the title says - added a new translation key for "Fields", while preserving the original one
examineManagement_fieldsin lowercase.This new translation key can be used in other parts of backoffice along with the existing
general_fieldtranslation.I also made the
uui-scroll-container100% height.I think we can just use
overflow-y: autoinstead ofoverflow-y: scroll;?So it looks like this:
but ideally remove padding in modal
#mainand add to scroll container instead?