Skip to content

Conversation

@bjarnef
Copy link
Contributor

@bjarnef bjarnef commented Sep 24, 2025

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes #20234

Description

As the title says - added a new translation key for "Fields", while preserving the original one examineManagement_fields in lowercase.

This new translation key can be used in other parts of backoffice along with the existing general_field translation.

image

I also made the uui-scroll-container 100% height.

I think we can just use overflow-y: auto instead of overflow-y: scroll;?

So it looks like this:

image image

but ideally remove padding in modal #main and add to scroll container instead?

Copilot AI review requested due to automatic review settings September 24, 2025 19:50
@github-actions
Copy link

Hi there @bjarnef, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new general translation key "fields" (plural) to complement the existing "field" (singular) translation, and updates the Examine Management Dashboard to use the new general translation instead of the examine-specific one.

  • Adds "fields" translation key to all language files (en, da, nb, pt, vi)
  • Updates Examine searcher table header to use general_fields instead of examineManagement_fields
  • Updates Examine fields settings modal headline to use general_fields

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
section-view-examine-searchers.ts Updates table header to use general_fields translation key
examine-fields-settings-modal.element.ts Updates modal headline to use general_fields translation key
en.ts Adds "fields" translation for English
da.ts Adds "fields" translation for Danish
nb.ts Adds "fields" translation for Norwegian
pt.ts Adds "fields" translation for Portuguese
vi.ts Adds "fields" translation for Vietnamese

@AndyButland AndyButland changed the title Add a new general translation for "Fields" Localization/UX: Add a new general translation for "Fields" Sep 25, 2025
@AndyButland AndyButland changed the base branch from main to v17/dev September 25, 2025 04:47
Copy link
Contributor

@AndyButland AndyButland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bjarnef - looks good to me when I've run it locally. Have retargeted for 17 as that's the release this will now go in.

@AndyButland AndyButland enabled auto-merge (squash) September 25, 2025 04:56
@AndyButland AndyButland merged commit b1956de into umbraco:v17/dev Sep 25, 2025
27 checks passed
@bjarnef bjarnef deleted the v16/bugfix/20234-examine-management-fields branch September 25, 2025 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Examine fields modal

2 participants