V16: Creating a new sub template should not show Discard Changes dialog #20068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielslyngsoe
approved these changes
Sep 3, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR resolves an issue where creating a new sub template would incorrectly show a "Discard Changes" dialog by ensuring the master template is properly set during template creation and loading.
- Ensures master template is set immediately when loading existing templates
- Sets the master template preset when creating new sub templates based on the parent
- Removes conditional wrapping that could delay master template assignment
...raco.Web.UI.Client/src/packages/templating/templates/workspace/template-workspace.context.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sets the masterTemplate at each opportunity to avoid Discard Changes dialog.
How to test