Prevents the removal of all user groups from a user #19995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR prevents users from having all their user groups removed during updates, maintaining consistency with user creation/invitation validation and aligning with Umbraco 13 behavior.
- Adds validation to reject user updates that would result in zero user groups
- Updates error message to be more generic for both create and update scenarios
- Includes integration test coverage for the new validation
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Umbraco.Core/Services/UserService.cs | Adds validation to prevent updating a user to have no groups |
| src/Umbraco.Cms.Api.Management/Controllers/User/UserOrCurrentUserControllerBase.cs | Updates error message to cover both create and update scenarios |
| tests/Umbraco.Tests.Integration/Umbraco.Core/Services/UserServiceCrudTests.Update.cs | Adds test to verify users cannot be updated to have no groups |
# Conflicts: # tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Users/User.spec.ts
nikolajlauridsen
approved these changes
Aug 27, 2025
Contributor
nikolajlauridsen
left a comment
nikolajlauridsen
left a comment
There was a problem hiding this comment.
Looks good, tests good 👍
nikolajlauridsen
deleted the
v16/bugfix/prevent-remove-all-groups-from-user
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Fixes #19992
Description
We currently have restrictions such that you can't create or invite a user without specifying at least one user group.
This aligns the behaviour for updates to prevent removing all groups (and also aligns with what we had in 13, as the linked issue points out).
Testing
For a user, verify that you can't remove all user groups from them. If you attempt to, the following response in the UI should be seen and the update rejected.