-
Notifications
You must be signed in to change notification settings - Fork 2.8k
V16: Adds a state for "forbidden" for entities that return 403 (Access denied) #19557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note: One interesting finding is that base entities (those using the base view, such as users, groups, data-types, etc.) handle "not found" - and now also "forbidden" - as Lit states ( |
…roperties to the object
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-ground-017b08103-19557.westeurope.6.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-ground-017b08103-19557.westeurope.6.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-ground-017b08103-19557.westeurope.6.azurestaticapps.net |
This pull request introduces enhancements to error handling and user feedback mechanisms in the
Umbraco.Web.UI.Clientproject. Specifically, it improves localization support for error messages across multiple languages, refines the handling of forbidden and not-found states, and adds new UI components to display these states.Fixes #18533
Below is a breakdown of the most important changes:
Screenshots
📄 Document not found
👤 User group not found (base entity)
How to test
Verify forbidden:
Verify not found:
Mock server
npm run dev:mock) has "Forbidden" entries for most entities, so test those out - member (groups), user (groups), dictionary, media, etc.)Changes
Localization Enhancements
src/assets/lang/da.ts) [1] [2] German (src/assets/lang/de.ts) [3] [4] and English (src/assets/lang/en.ts) [5] [6].Error Handling Improvements
UmbTryExecuteControllerto handle additional HTTP error statuses (400, 401, 403, 404) gracefully without displaying notifications, allowing the UI to manage these errors. (src/packages/core/resources/try-execute/try-execute.controller.ts).UI Components for Error States
umb-route-forbiddencomponent to display a "Forbidden" message for restricted routes. (src/packages/core/router/route/forbidden/route-forbidden.element.ts).umb-entity-detail-forbiddencomponent to show a "Forbidden" message for restricted entity details. (src/packages/core/workspace/entity-detail/global-components/entity-detail-forbidden.element.ts).Workspace Context Updates
UmbEntityDetailWorkspaceContextBaseto manage forbidden states using a newforbiddenstate manager. (src/packages/core/workspace/entity-detail/entity-detail-workspace-base.ts) [1] [2] [3] [4].entity-detail-workspace-editor.element.tsanddocument-workspace-editor.element.ts) to render forbidden states and adjust routing accordingly. (src/packages/core/workspace/entity-detail/global-components/entity-detail-workspace-editor.element.ts) [1] [2] and (src/packages/documents/documents/workspace/document-workspace-editor.element.ts) [3] [4] [5].Routing Adjustments
umb-route-forbiddencomponent in the router index file to integrate with routing logic. (src/packages/core/router/route/index.ts).