V16-RC: Typings error with http client #19489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a typings error with the HTTP client by promoting "@hey-api/client-fetch" from devDependencies to dependencies so that it is correctly bundled on npm.
- Moves "@hey-api/client-fetch" from devDependencies to dependencies
- Fixes JSON formatting by adding the missing comma after "uuid"
Files not reviewed (1)
- src/Umbraco.Web.UI.Client/package-lock.json: Language not supported
lauraneto
approved these changes
Jun 5, 2025
Contributor
lauraneto
left a comment
lauraneto
left a comment
There was a problem hiding this comment.
The error that I was seeing is gone now. Thanks! 🙌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This promotes
@hey-api/client-fetchfrom devDependencies to dependencies because it is referenced on npm.