Skip to content

Conversation

@kjac
Copy link
Contributor

@kjac kjac commented Apr 28, 2025

Prerequisites

  • I have added steps to test this contribution in the description below

Description

The Delivery API current outputs the "global" update date for culture variant content, which makes it hard to detect culture specific changes.

This PR updates the Delivery API output, so the updateDate property reflects the "culture date" of the requested content.

Testing this PR

Verify that:

  • updateDate reflects the "culture date" for culture variant content.
  • updateDate still works for invariant content.

image

Copy link
Contributor

@AndyButland AndyButland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and tests all look good to me.

Tested with the same setup as the linked PR - with this data output in Razor:

Published culture date (en): 4/29/2025 4:27:12 AM
Published culture date (it): 4/25/2025 2:23:13 PM

Request to retrieve item with en-US language:

{
    "contentType": "testPage",
    "name": "Test Page",
    "createDate": "2025-04-23T12:09:24.693Z",
    "updateDate": "2025-04-29T04:27:12.2159775Z",
    ...

Request to retrieve item with it language:

{
    "contentType": "testPage",
    "name": "Test Page",
    "createDate": "2025-04-23T12:09:24.693Z",
    "updateDate": "2025-04-25T14:23:13.267Z",
    ...

Request for another invariant page also returns the expected value.

@AndyButland AndyButland self-requested a review April 29, 2025 05:00
@AndyButland AndyButland merged commit ae54b92 into release/16.0 Apr 29, 2025
22 checks passed
@AndyButland AndyButland deleted the v16/feature/delivery-api-culture-variant-update-dates branch April 29, 2025 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants