-
Notifications
You must be signed in to change notification settings - Fork 2.8k
V16: Removes TinyMCE (client-side) #18889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Promoted from TinyMCE package code.
to remove the "[Tiptap]" suffix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request removes all client‑side references, configurations, and assets related to TinyMCE, thereby decommissioning the legacy TinyMCE RTE property editor. Key changes include:
- Deletion of the TinyMCE multi‑URL picker plugin and its associated manifest.
- Removal of TinyMCE assets, external imports, and related helper functions.
- Cleaning up mock data and configurations that referenced TinyMCE.
Reviewed Changes
Copilot reviewed 70 out of 75 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Umbraco.Web.UI.Client/src/packages/multi-url-picker/tiny-mce-plugin/tiny-mce-multi-url-picker.plugin.ts | Removed the TinyMCE multi‑URL picker plugin implementation. |
| src/Umbraco.Web.UI.Client/src/packages/multi-url-picker/tiny-mce-plugin/manifests.ts | Removed the manifest for the TinyMCE multi‑URL picker plugin. |
| src/Umbraco.Web.UI.Client/src/packages/multi-url-picker/manifests.ts | Removed spreading of TinyMCE manifests from global package manifests. |
| src/Umbraco.Web.UI.Client/src/packages/media/media/utils/index.ts | Removed legacy media helper functions that were specific to TinyMCE. |
| src/Umbraco.Web.UI.Client/src/packages/media/media/index.ts | Removed export of the media helper utilities as they are no longer needed. |
| src/Umbraco.Web.UI.Client/src/mocks/handlers/manifests.handlers.ts | Removed mock TinyMCE plugin entry from handler configurations. |
| src/Umbraco.Web.UI.Client/src/mocks/data/document/document.data.ts | Removed TinyMCE property editor configuration from document mock data. |
| src/Umbraco.Web.UI.Client/src/mocks/data/document-type/document-type.data.ts | Removed document type configuration entries for TinyMCE. |
| src/Umbraco.Web.UI.Client/src/mocks/data/data-type/data-type.data.ts | Removed data type configuration for the TinyMCE Rich Text Editor. |
| src/Umbraco.Web.UI.Client/src/external/tinymce/index.ts | Removed the external TinyMCE import and initialization wrapper. |
| src/Umbraco.Web.UI.Client/src/apps/backoffice/backoffice.element.ts | Removed the TinyMCE package import from core package imports. |
| src/Umbraco.Web.UI.Client/public-assets/App_Plugins/tinyMcePlugin.js | Removed the public asset for the TinyMCE mock plugin. |
| src/Umbraco.Web.UI.Client/eslint.config.js | Updated lint configuration by dropping an exclusion for TinyMCE defaults. |
Files not reviewed (5)
- src/Umbraco.Web.UI.Client/.gitignore: Language not supported
- src/Umbraco.Web.UI.Client/.vscode/settings.json: Language not supported
- src/Umbraco.Web.UI.Client/package-lock.json: Language not supported
- src/Umbraco.Web.UI.Client/package.json: Language not supported
- src/Umbraco.Web.UI.Client/src/css/rte-content.css: Language not supported
Comments suppressed due to low confidence (2)
src/Umbraco.Web.UI.Client/eslint.config.js:72
- Confirm that 'input-tiny-mce.defaults' is no longer needed; if the file still exists, update the lint configuration to avoid unexpected lint errors.
exclusion of 'input-tiny-mce.defaults' removed from excludedFileNames
src/Umbraco.Web.UI.Client/src/mocks/data/document/document.data.ts:948
- Verify that no tests or document rendering flows rely on the removed TinyMCE configuration, and update the test fixtures if necessary.
Removal of the TinyMCE property editor configuration for the 'tinymce' alias
to add the "[Tiptap]" suffix back in.
iOvergaard
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionally, it works. Now it remains to nurse the tests through and make sure we properly clean up there. Approving now just in case it works this time and auto-merges 🎉
I'd accidentally removed this in PR #18889. Adding it back in to the "block-rte" package.
I'd accidentally removed this in PR #18889. Adding it back in to the "block-rte" package.
Description
Removes TinyMCE RTE property-editor from the client-side codebase.
Note
Tiptap RTE configuration has dependencies on the Dimensions and Max Image Size property-editors, (that were part of the TinyMCE package). To resolve this, the Dimensions property-editor has been relocated to the Property Editors package, and Max Image Size replaces with the general Integer property-editor (with
min=0configuration).