Skip to content

Conversation

@NguyenThuyLan
Copy link
Contributor

@NguyenThuyLan NguyenThuyLan commented Mar 6, 2025

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes

Description

This PR fixes the issue #18535

After fixed:
image

@bjarnef
Copy link
Contributor

bjarnef commented Mar 6, 2025

That's a pretty long name 😅

I think it would be better to hide overflow using ellipsis.

white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;

or line clamp specific 2 lines which is supported in most modern browsers: https://caniuse.com/?search=line-clamp

display: -webkit-box;
-webkit-line-clamp: 2;
-webkit-box-orient: vertical;
overflow: hidden;
text-overflow: ellipsis;

@NguyenThuyLan
Copy link
Contributor Author

Thanks @bjarnef , I have changed my PR, we will display the user name with ellipsis at the end and when hovering, the user can see the full text.

nhudinh0309 and others added 4 commits March 17, 2025 10:14
# Conflicts:
#	tests/Umbraco.Tests.AcceptanceTest/package-lock.json
#	tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/DocumentType/DocumentTypeDesignTab.spec.ts
Copy link
Member

@leekelleher leekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved the merge conflict and tested out, looking good! 🚀

@nielslyngsoe nielslyngsoe disabled auto-merge March 19, 2025 15:41
Copy link
Member

@nielslyngsoe nielslyngsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added a few comments :-)

@nielslyngsoe
Copy link
Member

I now see that we have the user-name in the Not logged in-message. That is not needed. The reader can read the name two lines above. I'm not sure why it ever has been like this but lets get rid of the name now that we are correcting this.

So it should look like this:
image

Making the 'not logged in yet'-message the replacement for the missing date. In similar manner we do not render the name when the user has logged in.

And with umbraco/Umbraco.UI#1036 then the card seems good.

Then I would actually revert the ellipsis from the date part here — we know the length of this message, no need to hide it.

+ other code formatting tweaks.
Copy link
Contributor

@iOvergaard iOvergaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a fallback key and <umb-localize />. LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants