From e53024ab7534df8405e770b72a2415e636afd972 Mon Sep 17 00:00:00 2001
From: leekelleher <leekelleher@gmail.com>
Date: Thu, 13 Feb 2025 17:35:48 +0000
Subject: [PATCH] Help Header App, code tidy-up

---
 .../header-app/help-header-app.element.ts     | 32 ++++++-------------
 1 file changed, 10 insertions(+), 22 deletions(-)

diff --git a/src/Umbraco.Web.UI.Client/src/packages/help/header-app/help-header-app.element.ts b/src/Umbraco.Web.UI.Client/src/packages/help/header-app/help-header-app.element.ts
index f841a35ef6f3..2b4aca145028 100644
--- a/src/Umbraco.Web.UI.Client/src/packages/help/header-app/help-header-app.element.ts
+++ b/src/Umbraco.Web.UI.Client/src/packages/help/header-app/help-header-app.element.ts
@@ -1,17 +1,12 @@
 import { UMB_HELP_MENU_ALIAS } from '../menu/index.js';
-import type { CSSResultGroup } from '@umbraco-cms/backoffice/external/lit';
-import { css, html, customElement, state, nothing } from '@umbraco-cms/backoffice/external/lit';
-import { UmbHeaderAppButtonElement } from '@umbraco-cms/backoffice/components';
+import { customElement, html, nothing, state } from '@umbraco-cms/backoffice/external/lit';
 import { umbExtensionsRegistry } from '@umbraco-cms/backoffice/extension-registry';
-import type { ManifestMenu } from '@umbraco-cms/backoffice/menu';
 import { UmbExtensionsManifestInitializer } from '@umbraco-cms/backoffice/extension-api';
+import { UmbHeaderAppButtonElement } from '@umbraco-cms/backoffice/components';
+import type { ManifestMenu } from '@umbraco-cms/backoffice/menu';
 
-const elementName = 'umb-help-header-app';
-@customElement(elementName)
+@customElement('umb-help-header-app')
 export class UmbHelpHeaderAppElement extends UmbHeaderAppButtonElement {
-	@state()
-	private _popoverOpen = false;
-
 	@state()
 	private _helpMenuHasMenuItems = false;
 
@@ -30,22 +25,15 @@ export class UmbHelpHeaderAppElement extends UmbHeaderAppButtonElement {
 		);
 	}
 
-	#onPopoverToggle(event: ToggleEvent) {
-		// TODO: This ignorer is just neede for JSON SCHEMA TO WORK, As its not updated with latest TS jet.
-		// eslint-disable-next-line @typescript-eslint/ban-ts-comment
-		// @ts-ignore
-		this._popoverOpen = event.newState === 'open';
-	}
-
 	override render() {
-		return html` ${this.#renderButton()} ${this.#renderPopover()} `;
+		return html`${this.#renderButton()} ${this.#renderPopover()}`;
 	}
 
 	#renderButton() {
 		if (!this._helpMenuHasMenuItems) return nothing;
 
 		return html`
-			<uui-button popovertarget="help-menu-popover" look="primary" label="help" compact>
+			<uui-button compact label=${this.localize.term('general_help')} look="primary" popovertarget="help-menu-popover">
 				<uui-icon name="icon-help-alt"></uui-icon>
 			</uui-button>
 		`;
@@ -53,12 +41,12 @@ export class UmbHelpHeaderAppElement extends UmbHeaderAppButtonElement {
 
 	#renderPopover() {
 		return html`
-			<uui-popover-container id="help-menu-popover" @toggle=${this.#onPopoverToggle}>
+			<uui-popover-container id="help-menu-popover" placement="top-end">
 				<umb-popover-layout>
 					<uui-scroll-container>
 						<umb-extension-slot
 							type="menu"
-							.filter="${(menu: ManifestMenu) => menu.alias === UMB_HELP_MENU_ALIAS}"
+							.filter=${(menu: ManifestMenu) => menu.alias === UMB_HELP_MENU_ALIAS}
 							default-element="umb-menu"></umb-extension-slot>
 					</uui-scroll-container>
 				</umb-popover-layout>
@@ -66,13 +54,13 @@ export class UmbHelpHeaderAppElement extends UmbHeaderAppButtonElement {
 		`;
 	}
 
-	static override styles: CSSResultGroup = [UmbHeaderAppButtonElement.styles, css``];
+	static override styles = UmbHeaderAppButtonElement.styles;
 }
 
 export { UmbHelpHeaderAppElement as element };
 
 declare global {
 	interface HTMLElementTagNameMap {
-		[elementName]: UmbHelpHeaderAppElement;
+		'umb-help-header-app': UmbHelpHeaderAppElement;
 	}
 }