Skip to content

Commit 494674d

Browse files
OskarKrugerOskar krugerleekelleher
authored
Entity Actions: More create button discernible text, extension of #20434 (#20458)
* added hovering and focus border to RTE * fix main to OG * fix to main again * I'm going to cry * Missing localiztion feature, maybe UmbLitElement? * added localization controller to fetch localized version * localization successful for viewActionsFor and CreateFor * clean up button text * Changed label for content header to display proper name * clean up code * Included button labels for media section * clean code * Relocated localization keys, as `actions_viewActionsFor` already existed. Also made into a function, to support a fallback label. * Simplified the "Create for" label/localization Removed the need for a `getCreateAriaLabel()` method. * Removed the double-localizations (of `actions_viewActionsFor`) as the "umb-entity-actions-bundle" component handles this now. * imports tidy-up * Simplified localization key condition * switched to new localization key for other sections for new labeling * Bumped `@umbraco/playwright-testhelpers` 16.0.55 https://github.com/umbraco/Umbraco.Playwright.Testhelpers/releases/tag/release%2F16.0.55 --------- Co-authored-by: Oskar kruger <[email protected]> Co-authored-by: leekelleher <[email protected]>
1 parent 4ba1866 commit 494674d

File tree

13 files changed

+16
-16
lines changed

13 files changed

+16
-16
lines changed

src/Umbraco.Web.UI.Client/src/packages/core/collection/action/create/manifests.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ export const manifests: Array<UmbExtensionManifest | UmbExtensionManifestKind> =
1212
element: () => import('./collection-create-action.element.js'),
1313
weight: 1200,
1414
meta: {
15-
label: '#actions_create',
15+
label: '#actions_createFor',
1616
},
1717
},
1818
},

src/Umbraco.Web.UI.Client/src/packages/dictionary/entity-action/manifests.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ export const manifests: Array<UmbExtensionManifest> = [
1313
forEntityTypes: [UMB_DICTIONARY_ENTITY_TYPE, UMB_DICTIONARY_ROOT_ENTITY_TYPE],
1414
meta: {
1515
icon: 'icon-add',
16-
label: '#general_create',
16+
label: '#actions_createFor',
1717
additionalOptions: true,
1818
},
1919
},

src/Umbraco.Web.UI.Client/src/packages/documents/document-blueprints/entity-actions/create/manifests.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ export const manifests: Array<UmbExtensionManifest> = [
1111
forEntityTypes: [UMB_DOCUMENT_BLUEPRINT_ROOT_ENTITY_TYPE, UMB_DOCUMENT_BLUEPRINT_FOLDER_ENTITY_TYPE],
1212
meta: {
1313
icon: 'icon-add',
14-
label: '#actions_create',
14+
label: '#actions_createFor',
1515
additionalOptions: true,
1616
},
1717
},

src/Umbraco.Web.UI.Client/src/packages/documents/document-types/entity-actions/create/manifests.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ export const manifests: Array<UmbExtensionManifest | UmbExtensionManifestKind> =
1717
],
1818
meta: {
1919
icon: 'icon-add',
20-
label: '#actions_create',
20+
label: '#actions_createFor',
2121
additionalOptions: true,
2222
headline: '#create_createUnder #treeHeaders_documentTypes',
2323
},

src/Umbraco.Web.UI.Client/src/packages/documents/documents/user-permissions/document/manifests.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ const permissions: Array<ManifestEntityUserPermission> = [
6565
forEntityTypes: [UMB_DOCUMENT_ENTITY_TYPE],
6666
meta: {
6767
verbs: ['Umb.Document.Create'],
68-
label: '#actions_create',
68+
label: '#actions_createFor',
6969
description: '#actionDescriptions_create',
7070
},
7171
},

src/Umbraco.Web.UI.Client/src/packages/language/entity-actions/manifests.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ export const manifests: Array<UmbExtensionManifest> = [
2323
forEntityTypes: [UMB_LANGUAGE_ROOT_ENTITY_TYPE],
2424
meta: {
2525
icon: 'icon-add',
26-
label: '#actions_create',
26+
label: '#actions_createFor',
2727
additionalOptions: true,
2828
},
2929
},

src/Umbraco.Web.UI.Client/src/packages/members/member-group/entity-actions/manifests.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ export const manifests: Array<UmbExtensionManifest> = [
1212
forEntityTypes: [UMB_MEMBER_GROUP_ROOT_ENTITY_TYPE],
1313
meta: {
1414
icon: 'icon-add',
15-
label: '#actions_create',
15+
label: '#actions_createFor',
1616
additionalOptions: true,
1717
},
1818
},

src/Umbraco.Web.UI.Client/src/packages/members/member/entity-actions/create/manifests.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ export const manifests: Array<UmbExtensionManifest> = [
1111
forEntityTypes: [UMB_MEMBER_ROOT_ENTITY_TYPE],
1212
meta: {
1313
icon: 'icon-add',
14-
label: '#actions_create',
14+
label: '#actions_createFor',
1515
additionalOptions: true,
1616
},
1717
},

src/Umbraco.Web.UI.Client/src/packages/templating/partial-views/entity-actions/create/manifests.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ export const manifests: Array<UmbExtensionManifest> = [
1111
forEntityTypes: [UMB_PARTIAL_VIEW_ROOT_ENTITY_TYPE, UMB_PARTIAL_VIEW_FOLDER_ENTITY_TYPE],
1212
meta: {
1313
icon: 'icon-add',
14-
label: '#actions_create',
14+
label: '#actions_createFor',
1515
additionalOptions: true,
1616
},
1717
},

src/Umbraco.Web.UI.Client/src/packages/templating/scripts/entity-actions/create/manifests.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ export const manifests: Array<UmbExtensionManifest> = [
1111
forEntityTypes: [UMB_SCRIPT_ROOT_ENTITY_TYPE, UMB_SCRIPT_FOLDER_ENTITY_TYPE],
1212
meta: {
1313
icon: 'icon-add',
14-
label: '#actions_create',
14+
label: '#actions_createFor',
1515
additionalOptions: true,
1616
},
1717
},

0 commit comments

Comments
 (0)