Skip to content

릴리즈 노트 피드백 반영, SUMMARY.md 수정 #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2020
Merged

Conversation

dvlprsh
Copy link
Member

@dvlprsh dvlprsh commented May 20, 2020

  1. facebook 코멘트에 달린 릴리즈 노트 피드백 반영

'Unfortunately'는 '운이 안 좋게도'보다는 '안타깝게도' 정도가 더 적당한 번역 아닐까요?

  1. SUMMARY.md에 TypeScript 3.9.md 추가

리뷰 부탁드립니다!!

Copy link
Member

@bumkeyy bumkeyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빠른 피드백 감사합니다 👍

@dvlprsh dvlprsh requested review from yeonjuan and guyeol May 21, 2020 00:00
@bumkeyy
Copy link
Member

bumkeyy commented May 21, 2020

[제안]
@dvlprsh
혹시 34 라인에

이건 이상한 행동입니다!

이 동작은 이상합니다!

로 변경하는 건 어떨까요?
읽다보니 조금 어색하네요...ㅎㅎ

@yeonjuan yeonjuan merged commit 15d4491 into master May 21, 2020
@yeonjuan yeonjuan deleted the fix-dvlprsh branch May 21, 2020 09:42
@dvlprsh
Copy link
Member Author

dvlprsh commented May 21, 2020

@bumkeyy
넵 후자가 더 자연스러운거 같습니다 :)

—————————————————
머지가 돼서 새로 pr해야겠네요ㅎㅎ;;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants