Merge remote-tracking branch 'origin/master' into release-3.7

Author: DanielRosenwasser

.github/ISSUE_TEMPLATE/Bug_report.md

@@ -15,8 +15,12 @@ Please help us by doing the following steps before logging an issue:
 Please fill in the *entire* template below.
 -->
 
-<!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
-**TypeScript Version:**  3.4.0-dev.201xxxxx
+<!--
+Please try to reproduce the issue with the latest published version. It may have already been fixed.
+For npm: `typescript@next`
+This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly
+-->
+**TypeScript Version:**  3.7.x-dev.201xxxxx
 
 <!-- Search terms you tried before logging this (so others can find this issue more easily) -->
 **Search Terms:**

.gitignore

@@ -61,9 +61,10 @@ internal/
 **/.DS_Store
 .settings
 **/.vs
-**/.vscode
+**/.vscode/*
 !**/.vscode/tasks.json
-!**/.vscode/settings.json
+!**/.vscode/settings.template.json
+!**/.vscode/launch.template.json
 !**/.vscode/extensions.json
 !tests/cases/projects/projectOption/**/node_modules
 !tests/cases/projects/NodeModulesSearch/**/*

.vscode/launch.template.json

@@ -0,0 +1,60 @@
+/* 
+
+  Copy this file into '.vscode/launch.json' or merge its
+  contents into your existing configurations.
+
+  If you want to remove the errors in comments for all JSON
+  files, add this to your settings in ~/.vscode/User/settings.json
+
+  "files.associations": {
+      "*.json": "jsonc"
+  },
+
+*/
+
+{
+  // Use IntelliSense to learn about possible attributes.
+  // Hover to view descriptions of existing attributes.
+  // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
+  "version": "0.2.0",
+  "configurations": [
+    {
+      "type": "node",
+      "protocol": "inspector",
+      "request": "launch",
+      "name": "Mocha Tests (currently opened test)",
+      "runtimeArgs": ["--nolazy"],
+      "program": "${workspaceRoot}/node_modules/mocha/bin/_mocha",
+      "args": [
+        "-u",
+        "bdd",
+        "--no-timeouts",
+        "--colors",
+        "built/local/run.js",
+        "-f",
+        // You can change this to be the name of a specific test file (without the file extension)
+        // to consistently launch the same test
+        "${fileBasenameNoExtension}",
+        "--skip-percent",
+        "0"
+      ],
+      "env": {
+        "NODE_ENV": "testing"
+      },
+      "sourceMaps": true,
+      "smartStep": true,
+      "preLaunchTask": "tests",
+      "console": "integratedTerminal",
+      "outFiles": [
+        "${workspaceRoot}/built/local/run.js"
+      ]
+    },
+    {
+      // See: https://github.com/microsoft/TypeScript/wiki/Debugging-Language-Service-in-VS-Code
+      "type": "node",
+      "request": "attach",
+      "name": "Attach to VS Code TS Server via Port",
+      "processId": "${command:PickProcess}"
+    }
+  ]
+}

.vscode/settings.json

@@ -0,0 +1,19 @@
+// Rename this file 'settings.json' or merge its
+// contents into your existing settings.
+{
+    "eslint.validate": [
+        {
+            "language": "typescript",
+            "autoFix": true
+        }
+    ],
+    "eslint.options": {
+        "rulePaths": ["./scripts/eslint/built/rules/"],
+        "ext": [".ts"]
+    },
+    // To use the last-known-good (LKG) compiler version:
+    // "typescript.tsdk": "lib"
+
+    // To use the locally built compiler, after 'npm run build':
+    // "typescript.tsdk": "built/local"
+}

.vscode/settings.template.json

@@ -160,6 +160,8 @@ You can debug with VS Code or Node instead with `gulp runtests --inspect=true`:
 gulp runtests --tests=2dArrays --inspect=true
 ```
 
+You can also use the [provided VS Code launch configuration](./.vscode/launch.template.json) to launch a debug session for an open test file. Rename the file 'launch.json', open the test file of interest, and launch the debugger from the debug panel (or press F5).
+
 ## Adding a Test
 
 To add a new test case, simply place a `.ts` file in `tests\cases\compiler` containing code that exemplifies the bugfix or change you are making.

CONTRIBUTING.md

@@ -90,8 +90,18 @@ const localize = async () => {
     }
 };
 
+const buildShims = () => buildProject("src/shims");
+const cleanShims = () => cleanProject("src/shims");
+cleanTasks.push(cleanShims);
+
+const buildDebugTools = () => buildProject("src/debug");
+const cleanDebugTools = () => cleanProject("src/debug");
+cleanTasks.push(cleanDebugTools);
+
+const buildShimsAndTools = parallel(buildShims, buildDebugTools);
+
 // Pre-build steps when targeting the LKG compiler
-const lkgPreBuild = parallel(generateLibs, series(buildScripts, generateDiagnostics));
+const lkgPreBuild = parallel(generateLibs, series(buildScripts, generateDiagnostics, buildShimsAndTools));
 
 const buildTsc = () => buildProject("src/tsc");
 task("tsc", series(lkgPreBuild, buildTsc));
@@ -107,7 +117,7 @@ task("watch-tsc", series(lkgPreBuild, parallel(watchLib, watchDiagnostics, watch
 task("watch-tsc").description = "Watch for changes and rebuild the command-line compiler only.";
 
 // Pre-build steps when targeting the built/local compiler.
-const localPreBuild = parallel(generateLibs, series(buildScripts, generateDiagnostics, buildTsc));
+const localPreBuild = parallel(generateLibs, series(buildScripts, generateDiagnostics, buildShimsAndTools, buildTsc));
 
 // Pre-build steps to use based on supplied options.
 const preBuild = cmdLineOptions.lkg ? lkgPreBuild : localPreBuild;

Gulpfile.js

@@ -42,7 +42,7 @@ with any additional questions or comments.
 
 ## Documentation
 
-*  [Quick tutorial](https://www.typescriptlang.org/docs/tutorial.html)
+*  [TypeScript in 5 minutes](https://www.typescriptlang.org/docs/handbook/typescript-in-5-minutes.html)
 *  [Programming handbook](https://www.typescriptlang.org/docs/handbook/basic-types.html)
 *  [Language specification](https://github.com/microsoft/TypeScript/blob/master/doc/spec.md)
 *  [Homepage](https://www.typescriptlang.org/)

README.md

@@ -441,7 +441,7 @@
   "Function_implementation_is_missing_or_not_immediately_following_the_declaration_2391": "Implementace funkce chybí nebo nenásleduje hned po deklaraci.",
   "Function_implementation_name_must_be_0_2389": "Název implementace funkce musí být {0}.",
   "Function_implicitly_has_return_type_any_because_it_does_not_have_a_return_type_annotation_and_is_ref_7024": "Funkce implicitně obsahuje návratový typ any, protože neobsahuje anotaci návratového typu a odkazuje se na ni přímo nebo nepřímo v jednom z jejích návratových výrazů.",
-  "Function_lacks_ending_return_statement_and_return_type_does_not_include_undefined_2366": "Ve funkci chybí koncový návratový příkaz a návratový typ neobsahuje undefined.",
+  "Function_lacks_ending_return_statement_and_return_type_does_not_include_undefined_2366": "Ve funkci chybí koncový příkaz return a návratový typ neobsahuje undefined.",
   "Function_overload_must_be_static_2387": "Přetížení funkce musí být statické.",
   "Function_overload_must_not_be_static_2388": "Přetížení funkce nesmí být statické.",
   "Generate_get_and_set_accessors_95046": "Generovat přístupové objekty get a set",

lib/cs/diagnosticMessages.generated.json

@@ -1032,7 +1032,7 @@
   "await_expression_is_only_allowed_within_an_async_function_1308": "Der Ausdruck \"await\" ist nur in einer asynchronen Funktion zulässig.",
   "await_expressions_cannot_be_used_in_a_parameter_initializer_2524": "await-Ausdrücke dürfen nicht in einem Parameterinitialisierer verwendet werden.",
   "baseUrl_option_is_set_to_0_using_this_value_to_resolve_non_relative_module_name_1_6106": "Die Option \"baseUrl\" ist auf \"{0}\" festgelegt. Dieser Wert wird verwendet, um den nicht relativen Modulnamen \"{1}\" aufzulösen.",
-  "can_only_be_used_in_an_object_literal_property_inside_a_destructuring_assignment_1312": "\"=\" kann nur in einer Objektliteraleigenschaft innerhalb eines Destrukturierungsauftrags verwendet werden.",
+  "can_only_be_used_in_an_object_literal_property_inside_a_destructuring_assignment_1312": "\"=\" kann nur in einer Objektliteraleigenschaft innerhalb eines Destrukturierungszuweisung verwendet werden.",
   "case_or_default_expected_1130": "\"case\" oder \"default\" wurde erwartet.",
   "class_expressions_are_not_currently_supported_9003": "class-Ausdrücke werden zurzeit nicht unterstützt.",
   "const_declarations_can_only_be_declared_inside_a_block_1156": "const-Deklarationen können nur innerhalb eines Blocks deklariert werden.",