Skip to content

Commit eb7c1ad

Browse files
authored
fix: internal createSignature support undefined declaration (microsoft#44109)
1 parent 6df16b3 commit eb7c1ad

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

src/compiler/types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4226,7 +4226,7 @@ namespace ts {
42264226
/* @internal */ isTypeAssignableTo(source: Type, target: Type): boolean;
42274227
/* @internal */ createAnonymousType(symbol: Symbol | undefined, members: SymbolTable, callSignatures: Signature[], constructSignatures: Signature[], stringIndexInfo: IndexInfo | undefined, numberIndexInfo: IndexInfo | undefined): Type;
42284228
/* @internal */ createSignature(
4229-
declaration: SignatureDeclaration,
4229+
declaration: SignatureDeclaration | undefined,
42304230
typeParameters: readonly TypeParameter[] | undefined,
42314231
thisParameter: Symbol | undefined,
42324232
parameters: readonly Symbol[],

src/services/codefixes/inferFromUsage.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1135,8 +1135,7 @@ namespace ts.codefix {
11351135
parameters.push(symbol);
11361136
}
11371137
const returnType = combineFromUsage(combineUsages(calls.map(call => call.return_)));
1138-
// TODO: GH#18217
1139-
return checker.createSignature(/*declaration*/ undefined!, /*typeParameters*/ undefined, /*thisParameter*/ undefined, parameters, returnType, /*typePredicate*/ undefined, length, SignatureFlags.None);
1138+
return checker.createSignature(/*declaration*/ undefined, /*typeParameters*/ undefined, /*thisParameter*/ undefined, parameters, returnType, /*typePredicate*/ undefined, length, SignatureFlags.None);
11401139
}
11411140

11421141
function addCandidateType(usage: Usage, type: Type | undefined) {

0 commit comments

Comments
 (0)