Small fix in getObjectLiteralIndexInfo

Fixes microsoft#38175

Author: elibarzilay

src/compiler/checker.ts

@@ -23470,8 +23470,8 @@ namespace ts {
 
         function getObjectLiteralIndexInfo(node: ObjectLiteralExpression, offset: number, properties: Symbol[], kind: IndexKind): IndexInfo {
             const propTypes: Type[] = [];
-            for (let i = 0; i < properties.length; i++) {
-                if (kind === IndexKind.String || isNumericName(node.properties[i + offset].name!)) {
+            for (let i = offset; i < properties.length; i++) {
+                if (kind === IndexKind.String || isNumericName(node.properties[i].name!)) {
                     propTypes.push(getTypeOfSymbol(properties[i]));
                 }
             }

tests/baselines/reference/checkDestructuringShorthandAssigment2.errors.txt

@@ -0,0 +1,14 @@
+tests/cases/compiler/checkDestructuringShorthandAssigment2.ts(4,7): error TS2525: Initializer provides no value for this binding element and the binding element has no default value.
+tests/cases/compiler/checkDestructuringShorthandAssigment2.ts(4,27): error TS2353: Object literal may only specify known properties, and '[k]' does not exist in type '{ x: any; }'.
+
+
+==== tests/cases/compiler/checkDestructuringShorthandAssigment2.ts (2 errors) ====
+    // GH #38175 -- should not crash while checking
+    
+    let o: any, k: any;
+    let { x } = { x: 1, ...o, [k]: 1 };
+          ~
+!!! error TS2525: Initializer provides no value for this binding element and the binding element has no default value.
+                              ~~~
+!!! error TS2353: Object literal may only specify known properties, and '[k]' does not exist in type '{ x: any; }'.
+    

tests/baselines/reference/checkDestructuringShorthandAssigment2.symbols

@@ -0,0 +1,14 @@
+=== tests/cases/compiler/checkDestructuringShorthandAssigment2.ts ===
+// GH #38175 -- should not crash while checking
+
+let o: any, k: any;
+>o : Symbol(o, Decl(checkDestructuringShorthandAssigment2.ts, 2, 3))
+>k : Symbol(k, Decl(checkDestructuringShorthandAssigment2.ts, 2, 11))
+
+let { x } = { x: 1, ...o, [k]: 1 };
+>x : Symbol(x, Decl(checkDestructuringShorthandAssigment2.ts, 3, 5))
+>x : Symbol(x, Decl(checkDestructuringShorthandAssigment2.ts, 3, 13))
+>o : Symbol(o, Decl(checkDestructuringShorthandAssigment2.ts, 2, 3))
+>[k] : Symbol([k], Decl(checkDestructuringShorthandAssigment2.ts, 3, 25))
+>k : Symbol(k, Decl(checkDestructuringShorthandAssigment2.ts, 2, 11))
+

tests/baselines/reference/checkDestructuringShorthandAssigment2.types

@@ -0,0 +1,17 @@
+=== tests/cases/compiler/checkDestructuringShorthandAssigment2.ts ===
+// GH #38175 -- should not crash while checking
+
+let o: any, k: any;
+>o : any
+>k : any
+
+let { x } = { x: 1, ...o, [k]: 1 };
+>x : any
+>{ x: 1, ...o, [k]: 1 } : any
+>x : number
+>1 : 1
+>o : any
+>[k] : number
+>k : any
+>1 : 1
+

tests/cases/compiler/checkDestructuringShorthandAssigment2.ts

@@ -0,0 +1,6 @@
+// @noEmit: true
+
+// GH #38175 -- should not crash while checking
+
+let o: any, k: any;
+let { x } = { x: 1, ...o, [k]: 1 };