Skip to content
This repository was archived by the owner on Sep 1, 2020. It is now read-only.

Commit 8247b8f

Browse files
lrytzadriaanm
authored andcommitted
Prepare build for inclusion of java8-compat
<h1>Allow mixed builds in ant</h1> The `JFunction` classes depend on the `FunctionN` traits, so the Java compiler needs the Scala library on the classpath. At the same time, while compiling the Scala library, the symbols for `JFunction` classes need to be available to emit indy-lambda closures. Therefore we pass the `JFunctions` as Java sources while compiling the Scala library. <h1>Upgrade versions of osgi tools</h1> Set the required java version in bnd files (JavaSE-1.8). Introduce `scala-swing.version.osgi` as a quick hack to allow manually deriving an osgi-friendly version number for the `scala-swing.version.number`. The latter is used to resolve the artifact, the osgi version is just so we can generate a bundle that osgi will accept. Bnd 1.50 doesn't work with Java 8 classfiles, so upgrade to 2.4.1. Also upgrade all other tools to make tests pass. For `org.eclipse.osgi` we moved to the group ID `org.eclipse.tycho`, where there's a newer version available. The osgi tests would fail with the most recent version available in the `org.eclipse.osgi` groupID. The new version of bnd only copies *classfiles* from the original into the resulting jar, while the old version also copied all other files. This caused osgi test failure with a `NoClassDefFound`, which was really due to a `NumberFormatException` in `ScalaVersion`, as it couldn't find the properties file to parse the version in... Include resources from source jar into osgi bundle as follows: ``` Include-Resource: @@SOURCE_JARNAME@ ``` This makes bnd copy all resources from the source jar. I ran the following on the osgi artifacts of this branch, and on 2.11.x: ``` for f in `find build/osgi -name '*.jar' -a -not -name '*src.jar'`; do unzip -l $f | grep -v '\.class' ; done ``` Comparing the two file lists, things look OK: https://gist.github.com/lrytz/be08db051a53eded192d
1 parent d2cffb9 commit 8247b8f

12 files changed

+61
-31
lines changed

build-ant-macros.xml

Lines changed: 19 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,9 @@
202202
<!-- overrides the output directory; used when building multiple projects into the same directory-->
203203
<attribute name="srcdir" default="@{project}"/>
204204
<attribute name="java-excludes" default=""/>
205+
<attribute name="mixed" default="NOPE"/>
205206
<sequential>
207+
<local name="mixed.true"/><condition property="mixed.true"><equals arg1="@{mixed}" arg2="true"/></condition>
206208
<!-- TODO: detect zinc anywhere on PATH
207209
use zinc for the quick stage if it's available;
208210
would use it for locker but something is iffy in sbt: get a class cast error on global phase -->
@@ -220,12 +222,14 @@
220222
<then>
221223
<scalacfork taskname="@{stage}.@{project}" jvmargs="${scalacfork.jvmargs}" compilerpathref="@{with}.compiler.path" destdir="${build-@{stage}.dir}/classes/@{destproject}" srcdir="${src.dir}/@{srcdir}" params="${scalac.args.@{stage}} @{args}">
222224
<include name="**/*.scala"/>
225+
<include name="**/*.java" if="mixed.true"/>
223226
<compilationpath refid="@{stage}.@{project}.build.path"/>
224227
</scalacfork>
225228
</then>
226229
<else>
227230
<scalacfork taskname="@{stage}.@{project}" jvmargs="${scalacfork.jvmargs}" compilerpathref="@{with}.compiler.path" destdir="${build-@{stage}.dir}/classes/@{destproject}" srcdir="${src.dir}/@{srcdir}" srcpath="@{srcpath}" params="${scalac.args.@{stage}} @{args}">
228231
<include name="**/*.scala"/>
232+
<include name="**/*.java" if="mixed.true"/>
229233
<compilationpath refid="@{stage}.@{project}.build.path"/>
230234
</scalacfork>
231235
</else>
@@ -270,6 +274,7 @@
270274
<attribute name="includes" default="comp.includes"/>
271275
<attribute name="java-excludes" default=""/>
272276
<attribute name="version" default=""/>
277+
<attribute name="mixed" default="NOPE"/>
273278
<!-- non-empty for scaladoc: use @{version}.version.number in property file-->
274279
<sequential>
275280
<staged-uptodate stage="@{stage}" project="@{project}">
@@ -279,9 +284,18 @@
279284
<do>
280285
<stopwatch name="@{stage}.@{project}.timer"/>
281286
<mkdir dir="${build-@{stage}.dir}/classes/@{project}"/>
282-
<staged-javac stage="@{stage}" project="@{project}" excludes="@{java-excludes}"/>
283-
<!-- always compile with javac for simplicity and regularity; it's cheap -->
284-
<staged-scalac with="@{with}" stage="@{stage}" project="@{project}" srcpath="@{srcpath}" args="@{args}" java-excludes="@{java-excludes}"/>
287+
<if>
288+
<equals arg1="@{mixed}" arg2="true"/>
289+
<then>
290+
<staged-scalac with="@{with}" stage="@{stage}" project="@{project}" srcpath="@{srcpath}" args="@{args}" java-excludes="@{java-excludes}" mixed="@{mixed}"/>
291+
<staged-javac stage="@{stage}" project="@{project}" excludes="@{java-excludes}"/>
292+
</then>
293+
<else>
294+
<staged-javac stage="@{stage}" project="@{project}" excludes="@{java-excludes}"/>
295+
<!-- always compile with javac for simplicity and regularity; it's cheap -->
296+
<staged-scalac with="@{with}" stage="@{stage}" project="@{project}" srcpath="@{srcpath}" args="@{args}" java-excludes="@{java-excludes}"/>
297+
</else>
298+
</if>
285299
<if>
286300
<equals arg1="@{version}" arg2=""/>
287301
<then>
@@ -474,7 +488,8 @@
474488
<filter token="SCALA_COMPILER_INTERACTIVE_VERSION" value="${scala-compiler-interactive.version.number}"/>
475489
<filter token="XML_VERSION" value="${scala-xml.version.number}" />
476490
<filter token="PARSER_COMBINATORS_VERSION" value="${scala-parser-combinators.version.number}" />
477-
<filter token="SCALA_SWING_VERSION" value="${scala-swing.version.number}" />
491+
<filter token="SCALA_SWING_VERSION" value="${scala-swing.version.osgi}" />
492+
<filter token="SOURCE_JARNAME" value="${@{project}.targetjar}"/>
478493
</filterset>
479494
</copy>
480495
<bnd classpath="${@{project}.jar}" eclipse="false" failok="false" exceptions="true" files="${build-osgi.dir}/${@{project}.name}.bnd" output="${build-osgi.dir}"/>

build.sbt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,7 @@ lazy val library = configureAsSubproject(project)
142142
.settings(generatePropertiesFileSettings: _*)
143143
.settings(
144144
name := "scala-library",
145+
compileOrder := CompileOrder.Mixed, // needed for JFunction classes in scala.runtime.java8
145146
scalacOptions in Compile ++= Seq[String]("-sourcepath", (scalaSource in Compile).value.toString),
146147
// Workaround for a bug in `scaladoc` that it seems to not respect the `-sourcepath` option
147148
// as a result of this bug, the compiler cannot even initialize Definitions without

build.xml

Lines changed: 24 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -272,35 +272,34 @@ TODO:
272272

273273
<!-- This task has an issue where if the user directory does not exist, so we create it above. UGH. -->
274274
<artifact:dependencies pathId="extra.tasks.classpath" filesetId="extra.tasks.fileset">
275-
<dependency groupId="biz.aQute" artifactId="bnd" version="1.50.0"/>
275+
<dependency groupId="biz.aQute.bnd" artifactId="biz.aQute.bnd" version="2.4.1"/>
276276
</artifact:dependencies>
277277

278278
<artifact:dependencies pathId="jarjar.classpath">
279279
<dependency groupId="com.googlecode.jarjar" artifactId="jarjar" version="1.3"/>
280280
</artifact:dependencies>
281281

282282
<!-- JUnit -->
283-
<property name="junit.version" value="4.11"/>
283+
<property name="junit.version" value="4.12"/>
284284
<artifact:dependencies pathId="junit.classpath" filesetId="junit.fileset">
285285
<dependency groupId="junit" artifactId="junit" version="${junit.version}"/>
286286
</artifact:dependencies>
287287
<copy-deps project="junit"/>
288288

289289
<!-- Pax runner -->
290-
<property name="pax.exam.version" value="3.5.0"/><!-- Last version which supports Java 6 -->
291-
<property name="osgi.felix.version" value="4.4.0"/>
292-
<property name="osgi.equinox.version" value="3.7.1"/>
290+
<property name="pax.exam.version" value="4.5.0"/>
291+
<property name="osgi.felix.version" value="5.0.1"/>
292+
<property name="osgi.equinox.version" value="3.10.100.v20150521-1310"/>
293293
<artifact:dependencies pathId="pax.exam.classpath" filesetId="pax.exam.fileset">
294-
<dependency groupId="org.ops4j.pax.exam" artifactId="pax-exam-container-native" version="${pax.exam.version}">
295-
<exclusion groupId="org.osgi" artifactId="org.osgi.core"/><!-- Avoid dragging in a dependency which requires Java >6 -->
296-
</dependency>
294+
<dependency groupId="org.ops4j.pax.exam" artifactId="pax-exam-container-native" version="${pax.exam.version}"/>
297295
<dependency groupId="org.ops4j.pax.exam" artifactId="pax-exam-junit4" version="${pax.exam.version}"/>
298296
<dependency groupId="org.ops4j.pax.exam" artifactId="pax-exam-link-assembly" version="${pax.exam.version}"/>
299-
<dependency groupId="org.ops4j.pax.url" artifactId="pax-url-aether" version="2.2.0"/>
300-
<dependency groupId="org.ops4j.pax.swissbox" artifactId="pax-swissbox-tracker" version="1.8.0"/>
301-
<dependency groupId="ch.qos.logback" artifactId="logback-core" version="1.1.2"/>
302-
<dependency groupId="ch.qos.logback" artifactId="logback-classic" version="1.1.2"/>
297+
<dependency groupId="org.ops4j.pax.url" artifactId="pax-url-aether" version="2.4.1"/>
298+
<dependency groupId="org.ops4j.pax.swissbox" artifactId="pax-swissbox-tracker" version="1.8.1"/>
299+
<dependency groupId="ch.qos.logback" artifactId="logback-core" version="1.1.3"/>
300+
<dependency groupId="ch.qos.logback" artifactId="logback-classic" version="1.1.3"/>
303301
<dependency groupId="junit" artifactId="junit" version="${junit.version}"/>
302+
<dependency groupId="org.slf4j" artifactId="slf4j-api" version="1.7.12"/>
304303
</artifact:dependencies>
305304
<copy-deps project="pax.exam"/>
306305

@@ -309,7 +308,7 @@ TODO:
309308
</artifact:dependencies>
310309

311310
<artifact:dependencies pathId="osgi.framework.equinox">
312-
<dependency groupId="org.eclipse.osgi" artifactId="org.eclipse.osgi" version="${osgi.equinox.version}"/>
311+
<dependency groupId="org.eclipse.tycho" artifactId="org.eclipse.osgi" version="${osgi.equinox.version}"/>
313312
</artifact:dependencies>
314313

315314
<artifact:remoteRepository id="sonatype-release" url="https://oss.sonatype.org/content/repositories/releases"/>
@@ -637,18 +636,21 @@ TODO:
637636

638637
<property name="swing.description" value="Scala Swing Library"/>
639638
<property name="swing.package" value="modules."/>
639+
<property name="swing.targetjar" value="scala-swing${scala-swing.cross}-${scala-swing.version.number}.jar"/>
640640
<property name="swing.jar" value="${scala-swing}"/>
641641
<property name="swing.src" value="false"/>
642642
<property name="swing.srcjar" value="${scala-swing-sources}"/>
643643

644644
<property name="parser-combinators.description" value="Scala Parser Combinators Library"/>
645645
<property name="parser-combinators.package" value="modules."/>
646+
<property name="parser-combinators.targetjar" value="scala-parser-combinators${scala-parser-combinators.cross}-${scala-parser-combinators.version.number}.jar"/>
646647
<property name="parser-combinators.jar" value="${scala-parser-combinators}"/>
647648
<property name="parser-combinators.src" value="false"/>
648649
<property name="parser-combinators.srcjar" value="${scala-parser-combinators-sources}"/>
649650

650651
<property name="xml.description" value="Scala XML Library"/>
651652
<property name="xml.package" value="modules."/>
653+
<property name="xml.targetjar" value="scala-xml${scala-xml.cross}-${scala-xml.version.number}.jar"/>
652654
<property name="xml.jar" value="${scala-xml}"/>
653655
<property name="xml.src" value="false"/>
654656
<property name="xml.srcjar" value="${scala-xml-sources}"/>
@@ -1091,7 +1093,8 @@ TODO:
10911093
<condition property="locker.locked"><available file="${build-locker.dir}/locker.locked"/></condition></target>
10921094

10931095
<target name="locker.lib" depends="locker.start" unless="locker.locked">
1094-
<staged-build with="starr" stage="locker" project="library" srcpath="${src.dir}/library" includes="lib.includes"/></target>
1096+
<!-- "mixed" needed for JFunction classes in scala.runtime.java8 -->
1097+
<staged-build with="starr" stage="locker" project="library" srcpath="${src.dir}/library" includes="lib.includes" mixed="true"/></target>
10951098

10961099
<target name="locker.reflect" depends="locker.lib" unless="locker.locked">
10971100
<staged-build with="starr" stage="locker" project="reflect"/></target>
@@ -1112,7 +1115,8 @@ TODO:
11121115
<target name="quick.start" depends="locker.done"/>
11131116

11141117
<target name="quick.lib" depends="quick.start">
1115-
<staged-build with="locker" stage="quick" project="library" srcpath="${src.dir}/library" includes="lib.rootdoc.includes"/></target>
1118+
<!-- "mixed" needed for JFunction classes in scala.runtime.java8 -->
1119+
<staged-build with="locker" stage="quick" project="library" srcpath="${src.dir}/library" includes="lib.rootdoc.includes" mixed="true"/></target>
11161120

11171121
<target name="quick.reflect" depends="quick.lib">
11181122
<staged-build with="locker" stage="quick" project="reflect"/> </target>
@@ -1246,7 +1250,8 @@ TODO:
12461250
BOOTSTRAPPING BUILD (STRAP)
12471251
============================================================================ -->
12481252
<target name="strap.done" depends="pack.done">
1249-
<staged-build with="pack" stage="strap" project="library" srcpath="${src.dir}/library" includes="lib.rootdoc.includes"/>
1253+
<!-- "mixed" needed for JFunction classes in scala.runtime.java8 -->
1254+
<staged-build with="pack" stage="strap" project="library" srcpath="${src.dir}/library" includes="lib.rootdoc.includes" mixed="true"/>
12501255
<staged-build with="pack" stage="strap" project="reflect"/>
12511256
<staged-build with="pack" stage="strap" project="compiler"/>
12521257
</target>
@@ -1466,9 +1471,9 @@ TODO:
14661471
srcdir="${test.junit.src}"
14671472
destdir="${test.junit.classes}"
14681473
classpathref="test.junit.compiler.build.path"
1469-
target="1.6"
1470-
source="1.5"
1471-
compiler="javac1.6"
1474+
target="1.8"
1475+
source="1.8"
1476+
compiler="javac1.8"
14721477
includes="**/*.java"/>
14731478
<scalacfork
14741479
destdir="${test.junit.classes}"

src/build/bnd/scala-compiler-doc.bnd

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,5 @@ ver: @SCALA_COMPILER_DOC_VERSION@
44
Bundle-Version: ${ver}
55
Export-Package: *;version=${ver}
66
Import-Package: scala.*;version="${range;[==,=+);@VERSION@}",*
7-
Bundle-RequiredExecutionEnvironment: JavaSE-1.6, JavaSE-1.7
7+
Bundle-RequiredExecutionEnvironment: JavaSE-1.8
8+
Include-Resource: @@SOURCE_JARNAME@

src/build/bnd/scala-compiler-interactive.bnd

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,5 @@ ver: @SCALA_COMPILER_INTERACTIVE_VERSION@
44
Bundle-Version: ${ver}
55
Export-Package: *;version=${ver}
66
Import-Package: scala.*;version="${range;[==,=+);@VERSION@}",*
7-
Bundle-RequiredExecutionEnvironment: JavaSE-1.6, JavaSE-1.7
7+
Bundle-RequiredExecutionEnvironment: JavaSE-1.8
8+
Include-Resource: @@SOURCE_JARNAME@

src/build/bnd/scala-compiler.bnd

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,5 @@ Import-Package: jline.*;resolution:=optional, \
99
scala.xml.*;version="${range;[====,====];@XML_VERSION@}";resolution:=optional, \
1010
scala.*;version="${range;[==,=+);${ver}}", \
1111
*
12-
Bundle-RequiredExecutionEnvironment: JavaSE-1.6, JavaSE-1.7
12+
Bundle-RequiredExecutionEnvironment: JavaSE-1.8
13+
Include-Resource: @@SOURCE_JARNAME@

src/build/bnd/scala-library.bnd

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,5 @@ ver: @VERSION@
44
Bundle-Version: ${ver}
55
Export-Package: *;version=${ver}
66
Import-Package: sun.misc;resolution:=optional, *
7-
Bundle-RequiredExecutionEnvironment: JavaSE-1.6, JavaSE-1.7
7+
Bundle-RequiredExecutionEnvironment: JavaSE-1.8
8+
Include-Resource: @@SOURCE_JARNAME@

src/build/bnd/scala-parser-combinators.bnd

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,5 @@ ver: @PARSER_COMBINATORS_VERSION@
44
Bundle-Version: ${ver}
55
Export-Package: *;version=${ver}
66
Import-Package: scala.*;version="${range;[==,=+);@VERSION@}",*
7-
Bundle-RequiredExecutionEnvironment: JavaSE-1.6, JavaSE-1.7
7+
Bundle-RequiredExecutionEnvironment: JavaSE-1.8
8+
Include-Resource: @@SOURCE_JARNAME@

src/build/bnd/scala-reflect.bnd

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,5 @@ Export-Package: *;version=${ver}
66
Import-Package: scala.*;version="${range;[==,=+);${ver}}", \
77
scala.tools.nsc;resolution:=optional;version="${range;[==,=+);${ver}}", \
88
*
9-
Bundle-RequiredExecutionEnvironment: JavaSE-1.6, JavaSE-1.7
9+
Bundle-RequiredExecutionEnvironment: JavaSE-1.8
10+
Include-Resource: @@SOURCE_JARNAME@

src/build/bnd/scala-swing.bnd

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,5 @@ ver: @SCALA_SWING_VERSION@
44
Bundle-Version: ${ver}
55
Export-Package: *;version=${ver}
66
Import-Package: scala.*;version="${range;[==,=+);@VERSION@}",*
7-
Bundle-RequiredExecutionEnvironment: JavaSE-1.6,JavaSE-1.7
7+
Bundle-RequiredExecutionEnvironment: JavaSE-1.8
8+
Include-Resource: @@SOURCE_JARNAME@

src/build/bnd/scala-xml.bnd

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,5 @@ ver: @XML_VERSION@
44
Bundle-Version: ${ver}
55
Export-Package: *;version=${ver}
66
Import-Package: scala.*;version="${range;[==,=+);@VERSION@}",*
7-
Bundle-RequiredExecutionEnvironment: JavaSE-1.6, JavaSE-1.7
7+
Bundle-RequiredExecutionEnvironment: JavaSE-1.8
8+
Include-Resource: @@SOURCE_JARNAME@

versions.properties

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ scala.binary.version=2.12.0-M1
2525
scala-xml.version.number=1.0.4
2626
scala-parser-combinators.version.number=1.0.4
2727
scala-swing.version.number=2.0.0-M2
28+
scala-swing.version.osgi=2.0.0.M2
2829
jline.version=2.12.1
2930
scala-asm.version=5.0.4-scala-2
3031

0 commit comments

Comments
 (0)