From 0ce2f682ed4fe94749244e5999a434f517f86a06 Mon Sep 17 00:00:00 2001 From: dkundel Date: Fri, 10 Jan 2020 14:52:29 -0800 Subject: [PATCH] fix(checks): change the expected node version By default Twilio Functions will now create environments using Node.js 10.17 instead of 8.10. This updates the checks, tests and docs --- .nvmrc | 2 +- .travis.yml | 3 +-- CONTRIBUTING.md | 4 ++-- src/checks/nodejs-version.ts | 2 +- 4 files changed, 5 insertions(+), 6 deletions(-) diff --git a/.nvmrc b/.nvmrc index 8d04a0f3..fecec1a1 100644 --- a/.nvmrc +++ b/.nvmrc @@ -1 +1 @@ -8.10 \ No newline at end of file +10.17 \ No newline at end of file diff --git a/.travis.yml b/.travis.yml index 00a39690..02427516 100644 --- a/.travis.yml +++ b/.travis.yml @@ -2,9 +2,8 @@ language: node_js node_js: - 'stable' - - '8' - - '9' - '10' + - '12' sudo: false diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 7080515a..141c3c7d 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -12,8 +12,8 @@ This project contains the CLI aspects of deploying Twilio Serverless as well as ## Requirements -Make sure you have Node.js 8.10 or newer installed. Due to compatibility with Twilio -Functions this project has to support at least Node.js 8.10. +Make sure you have Node.js 10.17 or newer installed. Due to compatibility with Twilio +Functions this project has to support at least Node.js 10.17. ## Setup diff --git a/src/checks/nodejs-version.ts b/src/checks/nodejs-version.ts index 4a286207..90993f7f 100644 --- a/src/checks/nodejs-version.ts +++ b/src/checks/nodejs-version.ts @@ -1,7 +1,7 @@ import { stripIndent } from 'common-tags'; import { logger } from '../utils/logger'; -const SERVERLESS_NODE_JS_VERSION = '8.10'; +const SERVERLESS_NODE_JS_VERSION = '10.17'; export function printVersionWarning( nodeVersion: string,