Skip to content

Conversation

@lcorbett89
Copy link

Hi Thomas,

I'd like to add support for what3words as a mapping provider, however I've not worked on a typescript package before and unsure with the testing part.

Would you be able to check if this is would be suitable for your package please? This is the link for the w3w site:

https://developer.what3words.com/tutorial/mobile-linking-to-the-what3words-app

Luke

@tschoffelen
Copy link
Owner

Awesome, thanks for doing the work on this!

One thing I was thinking, and please correct me if I'm wrong on this: if words is not specified, and you do have the W3W app installed, it will show this as an option, but will just show your current location in the app.

That seems like potentially confusing behaviour - should we only show W3W as an option if, either:

  1. You've explicitly asked for app: "w32" in the showLocation() call
  2. The words property is present

What do you think?

@lcorbett89
Copy link
Author

I agree, I think it would be best if the option to use w3w is shown only when the words property is set. Also, the lat/lng isn't really necessary for the w3w provider, however it is a required field in the validation for all other apps, so I'm not sure if this is worth excluding from the validation if the words property is included. Unfortunately the w3w linking doesn't support lat/lng as parameters, which would be a nice fallback.

I'll try and see where the best place to put this logic might be for excluding from the list of available apps.

Thanks for your feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants