Skip to content

Conversation

@tanmayv25
Copy link
Contributor

Adding documentation for the parameters added by this PR #125

krishung5
krishung5 previously approved these changes Apr 18, 2024
kthui
kthui previously approved these changes Apr 18, 2024
Copy link
Contributor

@kthui kthui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A very minor wording suggestion, otherwise LGTM!

@tanmayv25 tanmayv25 dismissed stale reviews from kthui and krishung5 via bb18868 April 18, 2024 23:33
@tanmayv25 tanmayv25 requested review from krishung5 and kthui April 18, 2024 23:34
@tanmayv25 tanmayv25 merged commit 5c97507 into main Apr 24, 2024
@tanmayv25 tanmayv25 deleted the tanmayv-threading branch April 24, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants