Fix PHP8.2: Deprecated: Creation of dynamic property errors

[AnupamaSarjoshi]

Hi Richard,

As discussed, I have worked on the PHP8.2 deprecation errors and have fixed them on top of development branch.
Also, I have updated the CI workflow to include the testing for PHP8.2 and and PHP8.1.

As there were few deprecation errors in moodle-qbehaviour_adaptive_adapted_for_coderunner plugin (which I have updated and will create a pull request and send for review), I used the following commit for testing purpose.
For testing, updated ci workflow to install fixed CR adaptive plugin

There were some existing grunt failures which I noticed when I pulled the development branch. Have fixed those in the separate commit Fix grunt failures

Could you please review the fix?

Thanks,
Anupama

[trampgeek]

Thanks Anupama. Looks like lots of good fixes there. I'll revert the ci workflow commi to use the standard behaviour plugin rather than yours but other than that all looks good at first glance. I'll let you know of any changes I make after studying it in more detail.

[trampgeek]

Hi again Anupama. I've now reviewed all your changes. I tweaked a few types and comments but you've done a great job - one I was not looking forward to doing myself. I'm very grateful! Thanks again. And I apologise for the messy code in question.php - that class clearly needs some major refactoring. I wrote most of it over 10 years ago, when I really didn't have a clear idea what I was doing.

When I've done a bit more local testing I'll push the tweaks back to github, still in the development branch.

[AnupamaSarjoshi]

Thanks so much Richard :)