Fix PHP8.2: Deprecated: Creation of dynamic property errors (#189)

* For testing, updated ci workflow to install fixed CR adaptive plugin

* Fix grunt failures

* Update CI workflow to include PHP8.2

* Fix PHP8.2: Deprecated: Creation of dynamic property errors

Author: AnupamaSarjoshi

.github/workflows/ci.yml

@@ -9,6 +9,12 @@ jobs:
       fail-fast: false
       matrix:
         include:
+          - php: '8.2'
+            moodle-branch: 'master'
+            database: 'pgsql'
+          - php: '8.1'
+            moodle-branch: 'MOODLE_403_STABLE'
+            database: 'mariadb'
           - php: '8.0'
             moodle-branch: 'MOODLE_402_STABLE'
             database: 'pgsql'
@@ -30,7 +36,7 @@ jobs:
         options: --health-cmd pg_isready --health-interval 10s --health-timeout 5s --health-retries 3
 
       mariadb:
-        image: mariadb:10.5
+        image: mariadb:10.6
         env:
           MYSQL_USER: 'root'
           MYSQL_ALLOW_EMPTY_PASSWORD: "true"
@@ -83,7 +89,7 @@ jobs:
 
       - name: Install Moodle
         run: |
-          moodle-plugin-ci add-plugin trampgeek/moodle-qbehaviour_adaptive_adapted_for_coderunner
+          moodle-plugin-ci add-plugin --branch wip753140_adaptive AnupamaSarjoshi/moodle-qbehaviour_adaptive_adapted_for_coderunner
           moodle-plugin-ci install --plugin ./plugin --db-host=127.0.0.1
           moodle-plugin-ci add-config 'define("QTYPE_CODERUNNER_JOBE_HOST", "localhost:4000");'
         env:

amd/build/ajaxquestionloader.min.js

@@ -25,6 +25,28 @@
 use qtype_coderunner\constants;
 
 class qtype_coderunner_combinator_grader_outcome extends qtype_coderunner_testing_outcome {
+
+    /** @var ?string Html that is displayed before the result table. */
+    public $epiloguehtml;
+
+    /** @var ?string Html that is displayed after the result table. */
+    public $prologuehtml;
+
+    /** @var array */
+    public $columnformats;
+
+    /** @var bool If true, the question does not display the result table and no grading. */
+    public $outputonly;
+
+    /** @var ?string HTML feedback set for teacher that is hidden from student. */
+    public $instructorhtml;
+
+    /** @var ?number The grade, out of 1. */
+    public $fraction;
+
+    /** @var bool If true, is used when the question is to be used only to display the output and perhaps images from a run, with no mark. */
+    public $showoutputonly;
+
     // A list of the allowed attributes in the combinator template grader return value.
     public $allowedfields = ['fraction', 'prologuehtml', 'testresults', 'epiloguehtml',
                     'feedbackhtml', 'columnformats', 'showdifferences',

amd/build/ajaxquestionloader.min.js.map

@@ -0,0 +1,35 @@
+<?php
+// This file is part of CodeRunner - http://coderunner.org.nz/
+//
+// CodeRunner is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// CodeRunner is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with CodeRunner.  If not, see <http://www.gnu.org/licenses/>.
+
+namespace qtype_coderunner;
+
+defined('MOODLE_INTERNAL') || die();
+require_once($CFG->dirroot . '/question/engine/lib.php');
+
+/**
+ * An extension of question_display_options that includes the extra options used by the coderunner.
+ *
+ * @package   qtype_coderunner
+ * @copyright 2024 The Open University
+ * @license   http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
+ */
+class display_options extends \question_display_options {
+
+    /**
+     * @var bool
+     */
+    public $suppressruntestslink = false;
+}

classes/combinator_grader_outcome.php

@@ -23,6 +23,10 @@
  */
 
 class qtype_coderunner_html_wrapper {
+
+    /** @var string */
+    private $html;
+
     public function __construct($html) {
         $this->html = $html;
     }

classes/display_options.php

@@ -57,6 +57,12 @@ class qtype_coderunner_jobesandbox extends qtype_coderunner_sandbox {
     private $httpcode = null;    // HTTP response code.
     private $response = null;    // Response from HTTP request to server.
 
+    /** @var mixed Jobe server host name. */
+    private $jobeserver;
+
+    /** @var mixed Jobe server API-key. */
+    private $apikey;
+
     // Constructor gets languages from Jobe and stores them.
     // If $this->languages is left null, the Jobe server is down or
     // refusing requests or misconfigured. The actual HTTP returncode and response

classes/html_wrapper.php

@@ -36,6 +36,18 @@ class qtype_coderunner_jobrunner {
     private $testcases = null;       // The testcases (a subset of those in the question).
     private $allruns = null;         // Array of the source code for all runs.
 
+    /** @var ?array Array of sandbox params. */
+    private $sandboxparams = null;
+
+    /** @var ?string Language used to run the code. */
+    private $language = null;
+
+    /** @var ?array An associative array of template params.*/
+    private $templateparams = null;
+
+    /** @var bool True if this grading is occurring because the student clicked the precheck button. */
+    private $isprecheck = false;
+
     // Check the correctness of a student's code and possible extra attachments
     // as an answer to the given
     // question and and a given set of test cases (which may be empty or a

classes/jobesandbox.php

@@ -90,9 +90,9 @@ abstract class qtype_coderunner_sandbox {
 
 
 
-    public function __construct($user = null, $pass = null) {
+    public function __construct($user = null, $password = null) {
         $this->user = $user;
-        $this->pass = $pass;
+        $this->password = $password;
         $this->authenticationerror = false;
     }
 

classes/jobrunner.php

@@ -24,11 +24,25 @@
  */
 
 class qtype_coderunner_student {
+
+    /** @var int */
+    public $id;
+
+    /** @var string */
     public $username;
+
+    /** @var string */
     public $email;
+
+    /** @var string */
     public $firstname;
+
+    /** @var string */
     public $lastname;
 
+    /** @var bool Whether the user can view hidden test cases. */
+    public $canviewhidden;
+
     public function __construct($user) {
         if (!empty($user->username)) {
             $this->id        = $user->id;