Skip to content

TOML configuration of set_env should also support loading from environment files #3474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brianhelba opened this issue Jan 29, 2025 · 2 comments · Fixed by #3478
Closed

TOML configuration of set_env should also support loading from environment files #3474

brianhelba opened this issue Jan 29, 2025 · 2 comments · Fixed by #3478
Labels
enhancement help:wanted Issues that have been acknowledged, a solution determined and a PR might likely be accepted.

Comments

@brianhelba
Copy link

What's the problem this feature will solve?

Loading environment files in set_env was implemented by @gaborbernat in #1668 and is currently documented as being generally usable. However, it appears that the file| syntax and custom parsing code is incompatible with a TOML configuration of set_env.

Describe the solution you'd like

TOML configuration of set_env should support the ability to load environment files. This would probably be most elegant with some new syntax, as the file| syntax doesn't map cleanly onto the expected type of set_env in TOML.

Alternative Solutions

Alternatively, the documentation should be updated to clarify that the environment file loading / file| syntax is only supported in the legacy INI configuration file format.

@gaborbernat
Copy link
Member

PR welcome 👍

@gaborbernat gaborbernat added the help:wanted Issues that have been acknowledged, a solution determined and a PR might likely be accepted. label Jan 29, 2025
@juditnovak
Copy link
Contributor

I made an attempt to address the issue in #3478 . Please let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help:wanted Issues that have been acknowledged, a solution determined and a PR might likely be accepted.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants