#1218 fix -ve cannot be passed compound (#1224)

Author: gaborbernat

docs/changelog/1218.bugfix.rst

@@ -0,0 +1 @@
+using -v and -e connected (as -ve) fails - by :user:`gaborbernat`

src/tox/session/__init__.py

@@ -25,6 +25,7 @@
 from tox.util import set_os_env_var
 from tox.util.graph import stable_topological_sort
 from tox.util.path import ensure_empty_dir
+from tox.util.stdlib import suppress_output
 from tox.venv import VirtualEnv
 
 from .commands.help import show_help
@@ -48,8 +49,12 @@ def setup_reporter(args):
 
     parser = ArgumentParser(add_help=False)
     add_verbosity_commands(parser)
-    options, _ = parser.parse_known_args(args)
-    update_default_reporter(options.quiet_level, options.verbose_level)
+    with suppress_output():
+        try:
+            options, _ = parser.parse_known_args(args)
+            update_default_reporter(options.quiet_level, options.verbose_level)
+        except SystemExit:
+            pass
 
 
 def main(args):

src/tox/util/stdlib.py

@@ -1,11 +1,50 @@
 import sys
 import threading
+from contextlib import contextmanager
+from tempfile import TemporaryFile
 
 
 def is_main_thread():
+    """returns true if we are within the main thread"""
     cur_thread = threading.current_thread()
     if sys.version_info >= (3, 4):
         return cur_thread is threading.main_thread()
     else:
         # noinspection PyUnresolvedReferences
         return isinstance(cur_thread, threading._MainThread)
+
+
+# noinspection PyPep8Naming
+@contextmanager
+def suppress_output():
+    """suppress both stdout and stderr outputs"""
+    if sys.version_info > (3, 4):
+        from contextlib import redirect_stdout, redirect_stderr
+    else:
+
+        class _RedirectStream(object):
+
+            _stream = None
+
+            def __init__(self, new_target):
+                self._new_target = new_target
+                self._old_targets = []
+
+            def __enter__(self):
+                self._old_targets.append(getattr(sys, self._stream))
+                setattr(sys, self._stream, self._new_target)
+                return self._new_target
+
+            def __exit__(self, exctype, excinst, exctb):
+                setattr(sys, self._stream, self._old_targets.pop())
+
+        class redirect_stdout(_RedirectStream):
+            _stream = "stdout"
+
+        class redirect_stderr(_RedirectStream):
+            _stream = "stderr"
+
+    with TemporaryFile("wt") as file:
+        with redirect_stdout(file):
+            with redirect_stderr(file):
+                yield

tests/unit/session/test_session.py

@@ -356,3 +356,15 @@ def test_command_prev_fail_command_skip_post_run(cmd, initproj, mock_venv):
     have = result.out.replace(os.linesep, "\n")
     actual = have[len(have) - len(expected) :]
     assert actual == expected
+
+
+def test_help_compound_ve_works(cmd, initproj, monkeypatch):
+    initproj("test-0.1", {"tox.ini": ""})
+    result = cmd("-ve", "py", "-a")
+    result.assert_success(is_run_test_env=False)
+    assert not result.err
+    assert result.outlines[0].startswith("using")
+    assert result.outlines[1].startswith("using")
+    assert result.outlines[2] == "default environments:"
+    assert result.outlines[3] == "py -> [no description]"
+    assert len(result.outlines) == 4