Skip to content

Commit 7fbc23a

Browse files
committed
test(legacy[session]) Stabilize assertion (#552)
Fixes #551.
2 parents 274d4c9 + a6fd116 commit 7fbc23a

File tree

3 files changed

+7
-12
lines changed

3 files changed

+7
-12
lines changed

CHANGES

+1
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ $ pip install --user --upgrade --pre libtmux
2424
```sh
2525
ruff check --select ALL . --fix --unsafe-fixes --preview --show-fixes; ruff format .
2626
```
27+
- Tests: Stability fixes for legacy `test_select_pane` test (#552)
2728

2829
## libtmux 0.39.0 (2024-11-26)
2930

tests/legacy_api/test_session.py

+3-6
Original file line numberDiff line numberDiff line change
@@ -47,21 +47,18 @@ def test_select_window(session: Session) -> None:
4747
assert isinstance(selected_window1, Window)
4848
attached_window1 = session.attached_window
4949

50-
assert selected_window1 == attached_window1
51-
assert selected_window1.__dict__ == attached_window1.__dict__
50+
assert selected_window1.id == attached_window1.id
5251

5352
# again: tmux selects a window, moves to it, shows it as
5453
# attached_window
5554
selected_window2 = session.select_window(window_base_index + 1)
5655
assert isinstance(selected_window2, Window)
5756
attached_window2 = session.attached_window
5857

59-
assert selected_window2 == attached_window2
60-
assert selected_window2.__dict__ == attached_window2.__dict__
58+
assert selected_window2.id == attached_window2.id
6159

6260
# assure these windows were really different
63-
assert selected_window1 != selected_window2
64-
assert selected_window1.__dict__ != selected_window2.__dict__
61+
assert selected_window1.id != selected_window2.id
6562

6663

6764
def test_select_window_returns_Window(session: Session) -> None:

tests/test_session.py

+3-6
Original file line numberDiff line numberDiff line change
@@ -49,21 +49,18 @@ def test_select_window(session: Session) -> None:
4949
assert isinstance(selected_window1, Window)
5050
active_window1 = session.active_window
5151

52-
assert selected_window1 == active_window1
53-
assert selected_window1.__dict__ == active_window1.__dict__
52+
assert selected_window1.id == active_window1.id
5453

5554
# again: tmux selects a window, moves to it, shows it as
5655
# active_window
5756
selected_window2 = session.select_window(window_base_index + 1)
5857
assert isinstance(selected_window2, Window)
5958
active_window2 = session.active_window
6059

61-
assert selected_window2 == active_window2
62-
assert selected_window2.__dict__ == active_window2.__dict__
60+
assert selected_window2.id == active_window2.id
6361

6462
# assure these windows were really different
65-
assert selected_window1 != selected_window2
66-
assert selected_window1.__dict__ != selected_window2.__dict__
63+
assert selected_window1.id != selected_window2.id
6764

6865

6966
def test_select_window_returns_Window(session: Session) -> None:

0 commit comments

Comments
 (0)