Skip to content

RFE: drop use six and python<=3.7 #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kloczek opened this issue Mar 13, 2024 · 6 comments
Closed

RFE: drop use six and python<=3.7 #335

kloczek opened this issue Mar 13, 2024 · 6 comments

Comments

@kloczek
Copy link

kloczek commented Mar 13, 2024

Python 2.x has been EOSed +4 years ago. Last year python 3.7 support has been EOSed and this year end of Sep python 3.8 will be EOSed.
Because of above I think that it would be good start thinking about drop support for all those versions by:

  • release all already committed changes as new version (0.18.1?) (any plans to do that soon? 🤔 python-ecdsa-0.18.0...master shows +90 commits since last release)
  • mark that version as last version which supports python<=3.7
  • with flushed all currently committed changes on top of new version can be created branch like 0.18.x on which will be committed any changes which will maintain that legacy support if someone still will need python<=3.7 support.

Simple it is better to have clean code on the master instead in one source tree maintain multiple version.
I can share part of my work on that goal as draft PR if you want.

@kloczek

This comment was marked as abuse.

@tomato42
Copy link
Member

Python 2 will be supported as long as there's a supported RHEL version that uses python 2 by default.

@tomato42 tomato42 closed this as not planned Won't fix, can't repro, duplicate, stale Mar 13, 2024
@kloczek

This comment was marked as abuse.

@kloczek

This comment was marked as abuse.

@tomato42
Copy link
Member

Have you considered not telling people how they should develop software when the only reason for the request is some kind of personal vendetta against six or Python 2.7?

We've already been through this discussion in #304. This is your final warning, stop this behaviour or I'll block you from contributing to this project.

@kloczek

This comment was marked as abuse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants