From a156093d2356fcdfc9f36fda08f2097f46b6a67d Mon Sep 17 00:00:00 2001 From: Jonas Daniels Date: Wed, 21 May 2025 22:45:17 -0700 Subject: [PATCH 1/2] [SDK] fix avatar image detection on Node --- packages/thirdweb/src/utils/ens/avatar.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/thirdweb/src/utils/ens/avatar.ts b/packages/thirdweb/src/utils/ens/avatar.ts index d955c859976..cde75423126 100644 --- a/packages/thirdweb/src/utils/ens/avatar.ts +++ b/packages/thirdweb/src/utils/ens/avatar.ts @@ -74,7 +74,7 @@ async function isImageUri(options: ParseAvatarOptions): Promise { return false; } // fail in NodeJS, since the error is not cors but any other network issue - if (Object.hasOwn(globalThis, "Image")) { + if (!Object.hasOwn(globalThis, "Image")) { return false; } // in case of cors, use image api to validate if given url is an actual image From 767a4caa0c3e7cd52cb1701c798e67199f925d42 Mon Sep 17 00:00:00 2001 From: Jonas Daniels Date: Wed, 21 May 2025 23:45:00 -0700 Subject: [PATCH 2/2] Create shy-pigs-drive.md Signed-off-by: Jonas Daniels --- .changeset/shy-pigs-drive.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/shy-pigs-drive.md diff --git a/.changeset/shy-pigs-drive.md b/.changeset/shy-pigs-drive.md new file mode 100644 index 00000000000..2799bb73674 --- /dev/null +++ b/.changeset/shy-pigs-drive.md @@ -0,0 +1,5 @@ +--- +"thirdweb": patch +--- + +fix avatar image detection on Node