From e2922b235c8184e37d4964eb08c0b48e74c1b3c5 Mon Sep 17 00:00:00 2001 From: Prithvish Baidya Date: Thu, 15 May 2025 22:16:32 +0530 Subject: [PATCH 1/2] default to engine-cloud vault proxy --- packages/vault-sdk/src/sdk.ts | 26 +++++++++++++++++--------- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/packages/vault-sdk/src/sdk.ts b/packages/vault-sdk/src/sdk.ts index d35715a5993..7f1e5eb8679 100644 --- a/packages/vault-sdk/src/sdk.ts +++ b/packages/vault-sdk/src/sdk.ts @@ -106,13 +106,14 @@ function decryptFromEnclave( export type VaultClient = { baseUrl: string; publicKey: Uint8Array; + headers: Record; }; -export async function createVaultClient({ - baseUrl, -}: { - baseUrl: string; +export async function createVaultClient(clientOptions?: { + baseUrl?: string; + secretKey?: string; }): Promise { + const baseUrl = clientOptions?.baseUrl ?? "https://engine.thirdweb.com"; // Construct the full URL for the fetch call const url = new URL("api/v1/enclave", baseUrl).toString(); @@ -120,13 +121,18 @@ export async function createVaultClient({ publicKey: string; }; + const headers = { + // Indicate we accept JSON responses + Accept: "application/json", + ...(clientOptions?.secretKey + ? { "x-secret-key": clientOptions?.secretKey } + : {}), + }; + try { const response = await fetch(url, { method: "GET", - headers: { - // Indicate we accept JSON responses - Accept: "application/json", - }, + headers, }); // fetch doesn't throw on HTTP errors (like 4xx, 5xx) by default. @@ -149,7 +155,8 @@ export async function createVaultClient({ const publicKeyBytes = hexToBytes(data.publicKey); return { - baseUrl: baseUrl, // Store baseUrl + baseUrl, // Store baseUrl + headers, publicKey: publicKeyBytes, }; } catch (error) { @@ -180,6 +187,7 @@ async function sendRequest

({ const response = await fetch(url, { method: "POST", headers: { + ...client.headers, "Content-Type": "application/json", Accept: "application/json", // Good practice to specify accept header }, From da8dff0aa68231e3f1cab3ce28d5800ea74ca61c Mon Sep 17 00:00:00 2001 From: Prithvish Baidya Date: Fri, 16 May 2025 02:22:52 +0530 Subject: [PATCH 2/2] Create all-bears-visit.md --- .changeset/all-bears-visit.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/all-bears-visit.md diff --git a/.changeset/all-bears-visit.md b/.changeset/all-bears-visit.md new file mode 100644 index 00000000000..9eeac9ddcdf --- /dev/null +++ b/.changeset/all-bears-visit.md @@ -0,0 +1,5 @@ +--- +"@thirdweb-dev/vault-sdk": patch +--- + +added secret key and default vault url