From 42636ad1b3ae27469a6eb60418df81fa8948c15f Mon Sep 17 00:00:00 2001 From: Manan Tank Date: Tue, 27 Feb 2024 20:52:03 +0530 Subject: [PATCH 1/3] [react] remove const enums --- .../components/VerifyOwnershipWithPaper.tsx | 10 +++++----- .../src/payments/interfaces/WalletTypes.ts | 20 ++++++++++--------- 2 files changed, 16 insertions(+), 14 deletions(-) diff --git a/packages/react/src/payments/components/VerifyOwnershipWithPaper.tsx b/packages/react/src/payments/components/VerifyOwnershipWithPaper.tsx index bfc1a8a2698..ec54b0c0cea 100644 --- a/packages/react/src/payments/components/VerifyOwnershipWithPaper.tsx +++ b/packages/react/src/payments/components/VerifyOwnershipWithPaper.tsx @@ -27,11 +27,11 @@ interface VerifyOwnershipWithPaperProps { clientId?: string; } -const enum VERIFY_OWNERSHIP_WITH_PAPER_EVENT_TYPE { - USER_LOGIN_SUCCESS = "userLoginSuccess", - USER_LOGIN_FAILED = "userLoginFailed", - USER_CLOSE_LOGIN_PAGE = "userCloseLoginPage", -} +const VERIFY_OWNERSHIP_WITH_PAPER_EVENT_TYPE = { + USER_LOGIN_SUCCESS: "userLoginSuccess", + USER_LOGIN_FAILED: "userLoginFailed", + USER_CLOSE_LOGIN_PAGE: "userCloseLoginPage", +} as const; export const VerifyOwnershipWithPaper: React.FC< VerifyOwnershipWithPaperProps diff --git a/packages/react/src/payments/interfaces/WalletTypes.ts b/packages/react/src/payments/interfaces/WalletTypes.ts index ccd684b3555..3d83eae7fa6 100644 --- a/packages/react/src/payments/interfaces/WalletTypes.ts +++ b/packages/react/src/payments/interfaces/WalletTypes.ts @@ -1,11 +1,13 @@ // UNCHANGED -export const enum WalletType { - Preset = "Preset", - MetaMask = "metaMask", - CoinbaseWallet = "coinbaseWallet", - WalletConnect = "walletConnect", - Phantom = "Phantom", -} +const WalletTypeObj = { + Preset: "Preset", + MetaMask: "metaMask", + CoinbaseWallet: "coinbaseWallet", + WalletConnect: "walletConnect", + Phantom: "Phantom", +} as const; + +export type WalletType = (typeof WalletTypeObj)[keyof typeof WalletTypeObj]; export interface ConnectWalletProps { onWalletConnected: onWalletConnectedType; @@ -13,8 +15,8 @@ export interface ConnectWalletProps { } export type onWalletConnectFailType = (props: { - walletType: WalletType; - currentUserWalletType: WalletType; + walletType: typeof WalletTypeObj; + currentUserWalletType: typeof WalletTypeObj; error: Error; }) => void; export type onWalletConnectedType = (props: { From 25df743f9b9c262f488c3d51c7723ea18a5583bb Mon Sep 17 00:00:00 2001 From: Manan Tank Date: Tue, 27 Feb 2024 20:54:23 +0530 Subject: [PATCH 2/3] correction --- packages/react/src/payments/interfaces/WalletTypes.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/react/src/payments/interfaces/WalletTypes.ts b/packages/react/src/payments/interfaces/WalletTypes.ts index 3d83eae7fa6..6c619648e03 100644 --- a/packages/react/src/payments/interfaces/WalletTypes.ts +++ b/packages/react/src/payments/interfaces/WalletTypes.ts @@ -15,8 +15,8 @@ export interface ConnectWalletProps { } export type onWalletConnectFailType = (props: { - walletType: typeof WalletTypeObj; - currentUserWalletType: typeof WalletTypeObj; + walletType: WalletType; + currentUserWalletType: WalletType; error: Error; }) => void; export type onWalletConnectedType = (props: { From ec8b3107f536ecfd03d1a55a58898fa553f7abcf Mon Sep 17 00:00:00 2001 From: Manan Tank Date: Tue, 27 Feb 2024 22:39:34 +0530 Subject: [PATCH 3/3] add changeset --- .changeset/chilled-buses-hammer.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/chilled-buses-hammer.md diff --git a/.changeset/chilled-buses-hammer.md b/.changeset/chilled-buses-hammer.md new file mode 100644 index 00000000000..6f3f74b2ce1 --- /dev/null +++ b/.changeset/chilled-buses-hammer.md @@ -0,0 +1,5 @@ +--- +"@thirdweb-dev/react": patch +--- + +Remove const enums to object to fix issues with Next.js <13.5