Skip to content

[SDK] updateMetadata for edition drop contracts #2343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

joaquim-verges
Copy link
Member

Problem solved

Short description of the bug fixed or feature added

Changes made

  • Public API changes: list the public API changes made if any
  • Internal API changes: explain the internal logic changes

How to test

  • Automated tests: link to unit test file
  • Manual tests: step by step instructions on how to test

Contributor NFT

Paste in your wallet address below and we will airdrop you a special NFT when your pull request is merged.

Address:

@joaquim-verges joaquim-verges requested a review from a team February 22, 2024 02:51
Copy link

changeset-bot bot commented Feb 22, 2024

🦋 Changeset detected

Latest commit: 5a7c24f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@thirdweb-dev/sdk Patch
thirdweb Patch
@thirdweb-dev/react-core Patch
@thirdweb-dev/react-native Patch
@thirdweb-dev/react Patch
@thirdweb-dev/unity-js-bridge Patch
@thirdweb-dev/wallets Patch
@thirdweb-dev/auth Patch
@thirdweb-dev/react-native-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (7bbf3e2) 66.88% compared to head (5a7c24f) 66.95%.

Files Patch % Lines
...classes/internal/erc1155/erc-1155-lazy-mintable.ts 90.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2343      +/-   ##
==========================================
+ Coverage   66.88%   66.95%   +0.06%     
==========================================
  Files         293      293              
  Lines       11210    11241      +31     
  Branches     1557     1561       +4     
==========================================
+ Hits         7498     7526      +28     
- Misses       3080     3081       +1     
- Partials      632      634       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joaquim-verges joaquim-verges added this pull request to the merge queue Feb 22, 2024
Merged via the queue into main with commit a00917c Feb 22, 2024
@joaquim-verges joaquim-verges deleted the joaquim/update_1155 branch February 22, 2024 18:23
@jnsdls jnsdls mentioned this pull request Feb 22, 2024
jnsdls pushed a commit that referenced this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant