[Smart Wallet] Always force deploy on sign/auth, support 1271 #2341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g, always use 1271
🦋 Changeset detectedLatest commit: cf6ba08 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
0xFirekeeper
added
the
DO NOT MERGE
0xFirekeeper
changed the title
|
/release-pr |
0xFirekeeper
removed
the
DO NOT MERGE
|
@joaquim-verges @nkrishang ready to merge this, signing messages and authenticating should work with old and new factories |
packages/wallets/src/evm/connectors/smart-wallet/lib/erc4337-signer.ts
Outdated
Show resolved
Hide resolved
packages/wallets/src/evm/connectors/smart-wallet/lib/erc4337-signer.ts
Outdated
Show resolved
Hide resolved
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Support 712 based smart wallet signing and 1271 verification for new factories.
Remove optional deployment option.
Move smart-wallet signing functionality to erc4337-signer, all flows except user op signing should go through this.
Changes made
deployOnSignSmart Wallet option is no longer available.signMessageLegacyis now removed.How to test
Contributor NFT
Paste in your wallet address below and we will airdrop you a special NFT when your pull request is merged.
Address: