biome 2

Author: jnsdls

.github/workflows/CI.yml

@@ -63,7 +63,7 @@ jobs:
       - name: Setup Biome
         uses: biomejs/setup-biome@a9763ed3d2388f5746f9dc3e1a55df7f4609bc89 # v2.5.1
         with:
-          version: latest  
+          version: 2.0.0  
 
       - run: pnpm lint
 

.vscode/settings.json

@@ -1,25 +1,8 @@
 {
-  "editor.formatOnSave": true,
-  "editor.codeActionsOnSave": {
-    "source.fixAll.eslint": "explicit",
-    "source.organizeImports.biome": "explicit",
-    "quickfix.biome": "explicit"
-  },
-  "editor.defaultFormatter": "biomejs.biome",
-  "typescript.preferences.autoImportFileExcludePatterns": [
-    "./packages/thirdweb/src/exports"
-  ],
-  "typescript.preferences.autoImportSpecifierExcludeRegexes": [
-    "@radix-ui",
-    "next/router",
-    "next/dist",
-    "^lucide-react/dist/lucide-react.suffixed$"
-  ],
-  "typescript.tsdk": "node_modules/typescript/lib",
-  "[typescriptreact]": {
+  "[css]": {
     "editor.defaultFormatter": "biomejs.biome"
   },
-  "[typescript]": {
+  "[javascript]": {
     "editor.defaultFormatter": "biomejs.biome"
   },
   "[json]": {
@@ -28,14 +11,30 @@
   "[markdown]": {
     "editor.defaultFormatter": "esbenp.prettier-vscode"
   },
-  "[javascript]": {
+  "[typescript]": {
     "editor.defaultFormatter": "biomejs.biome"
   },
-  "[css]": {
+  "[typescriptreact]": {
     "editor.defaultFormatter": "biomejs.biome"
   },
+  "editor.codeActionsOnSave": {
+    "quickfix.biome": "explicit",
+    "source.fixAll.biome": "explicit"
+  },
+  "editor.defaultFormatter": "biomejs.biome",
+  "editor.formatOnSave": true,
   "eslint.workingDirectories": [
     { "pattern": "./packages/*/" },
     { "pattern": "./apps/*/" }
-  ]
+  ],
+  "typescript.preferences.autoImportFileExcludePatterns": [
+    "./packages/thirdweb/src/exports"
+  ],
+  "typescript.preferences.autoImportSpecifierExcludeRegexes": [
+    "@radix-ui",
+    "next/router",
+    "next/dist",
+    "^lucide-react/dist/lucide-react.suffixed$"
+  ],
+  "typescript.tsdk": "node_modules/typescript/lib"
 }

apps/dashboard/.eslintrc.js

@@ -1,51 +1,97 @@
 module.exports = {
+  env: {
+    browser: true,
+    node: true,
+  },
   extends: [
     "eslint:recommended",
     "plugin:@typescript-eslint/recommended",
     "plugin:@next/next/recommended",
     "plugin:storybook/recommended",
   ],
-  rules: {
-    "react-compiler/react-compiler": "error",
-    "no-restricted-syntax": [
-      "error",
-      {
-        selector: "CallExpression[callee.name='useEffect']",
-        message:
-          'Are you *sure* you need to use "useEffect" here? If you loading any async function prefer using "useQuery".',
+  overrides: [
+    // disable restricted imports in tw-components
+    {
+      files: "src/tw-components/**/*",
+      rules: {
+        "no-restricted-imports": ["off"],
       },
-      {
-        selector: "CallExpression[callee.name='createContext']",
-        message:
-          'Are you *sure* you need to use a "Context"? In almost all cases you should prefer passing props directly.',
+    },
+    // allow direct PostHog imports inside analytics helpers
+    {
+      files: "src/@/analytics/**/*",
+      rules: {
+        "no-restricted-imports": ["off"],
       },
-      {
-        selector: "CallExpression[callee.name='defineChain']",
-        message:
-          "Use useV5DashboardChain instead if you are using it inside a component",
+    },
+    // enable rule specifically for TypeScript files
+    {
+      files: ["*.ts", "*.tsx"],
+      rules: {
+        "@typescript-eslint/explicit-module-boundary-types": ["off"],
       },
-      {
-        selector: "CallExpression[callee.name='defineDashboardChain']",
-        message:
-          "Use useV5DashboardChain instead if you are using it inside a component",
+    },
+
+    // in test files, allow null assertions and anys and eslint is sometimes weird about the react-scope thing
+    {
+      files: ["*test.ts?(x)"],
+      rules: {
+        "@typescript-eslint/no-explicit-any": "off",
+        "@typescript-eslint/no-non-null-assertion": "off",
+
+        "react/display-name": "off",
       },
-      {
-        selector: "CallExpression[callee.name='mapV4ChainToV5Chain']",
-        message:
-          "Use useV5DashboardChain instead if you are using it inside a component",
+    },
+    // allow requires in non-transpiled JS files and logical key ordering in config files
+    {
+      files: [
+        "babel-node.js",
+        "*babel.config.js",
+        "env.config.js",
+        "next.config.js",
+        "webpack.config.js",
+        "packages/mobile-web/package-builder/**",
+      ],
+      rules: {},
+    },
+
+    // setupTests can have separated imports for logical grouping
+    {
+      files: ["setupTests.ts"],
+      rules: {
+        "import/newline-after-import": "off",
       },
-      {
-        selector: "CallExpression[callee.name='resolveScheme']",
-        message:
-          "resolveScheme can throw error if resolution fails. Either catch the error and ignore the lint warning or Use `resolveSchemeWithErrorHandler` / `replaceIpfsUrl` utility in dashboard instead",
+    },
+    // turn OFF unused vars via eslint
+    {
+      files: ["*.ts", "*.tsx"],
+      rules: {
+        "@next/next/no-img-element": "off",
+        "@typescript-eslint/no-unused-vars": "off",
       },
-    ],
+    },
+    // THIS NEEDS TO GO LAST!
+    {
+      extends: ["biome"],
+      files: ["*.ts", "*.js", "*.tsx", "*.jsx"],
+    },
+  ],
+  parser: "@typescript-eslint/parser",
+  parserOptions: {
+    ecmaFeatures: {
+      impliedStrict: true,
+      jsx: true,
+    },
+    ecmaVersion: 2019,
+    warnOnUnsupportedTypeScriptVersion: true,
+  },
+  plugins: ["@typescript-eslint", "react-compiler"],
+  rules: {
     "no-restricted-imports": [
       "error",
       {
         paths: [
           {
-            name: "@chakra-ui/react",
             // these are provided by tw-components, so we don't want to import them from chakra directly
             importNames: [
               "Card",
@@ -82,52 +128,77 @@ module.exports = {
             ],
             message:
               'Use the equivalent component from "tw-components" instead.',
+            name: "@chakra-ui/react",
           },
           {
-            name: "@chakra-ui/layout",
             message:
               "Import from `@chakra-ui/react` instead of `@chakra-ui/layout`.",
+            name: "@chakra-ui/layout",
           },
           {
-            name: "@chakra-ui/button",
             message:
               "Import from `@chakra-ui/react` instead of `@chakra-ui/button`.",
+            name: "@chakra-ui/button",
           },
           {
-            name: "@chakra-ui/menu",
             message:
               "Import from `@chakra-ui/react` instead of `@chakra-ui/menu`.",
+            name: "@chakra-ui/menu",
           },
           {
-            name: "next/navigation",
             importNames: ["useRouter"],
             message:
               'Use `import { useDashboardRouter } from "@/lib/DashboardRouter";` instead',
+            name: "next/navigation",
           },
           {
-            name: "lucide-react",
             importNames: ["Link", "Table", "Sidebar"],
             message:
               'This is likely a mistake. If you really want to import this - postfix the imported name with Icon. Example - "LinkIcon"',
+            name: "lucide-react",
           },
           {
-            name: "posthog-js",
             message:
               'Import "posthog-js" directly only within the analytics helpers ("src/@/analytics/*"). Use the exported helpers from "@/analytics/track" elsewhere.',
+            name: "posthog-js",
           },
         ],
       },
     ],
-  },
-  parser: "@typescript-eslint/parser",
-  plugins: ["@typescript-eslint", "react-compiler"],
-  parserOptions: {
-    ecmaVersion: 2019,
-    ecmaFeatures: {
-      impliedStrict: true,
-      jsx: true,
-    },
-    warnOnUnsupportedTypeScriptVersion: true,
+    "no-restricted-syntax": [
+      "error",
+      {
+        message:
+          'Are you *sure* you need to use "useEffect" here? If you loading any async function prefer using "useQuery".',
+        selector: "CallExpression[callee.name='useEffect']",
+      },
+      {
+        message:
+          'Are you *sure* you need to use a "Context"? In almost all cases you should prefer passing props directly.',
+        selector: "CallExpression[callee.name='createContext']",
+      },
+      {
+        message:
+          "Use useV5DashboardChain instead if you are using it inside a component",
+        selector: "CallExpression[callee.name='defineChain']",
+      },
+      {
+        message:
+          "Use useV5DashboardChain instead if you are using it inside a component",
+        selector: "CallExpression[callee.name='defineDashboardChain']",
+      },
+      {
+        message:
+          "Use useV5DashboardChain instead if you are using it inside a component",
+        selector: "CallExpression[callee.name='mapV4ChainToV5Chain']",
+      },
+      {
+        message:
+          "resolveScheme can throw error if resolution fails. Either catch the error and ignore the lint warning or Use `resolveSchemeWithErrorHandler` / `replaceIpfsUrl` utility in dashboard instead",
+        selector: "CallExpression[callee.name='resolveScheme']",
+      },
+    ],
+    "react-compiler/react-compiler": "error",
   },
   settings: {
     react: {
@@ -136,67 +207,4 @@ module.exports = {
       version: "detect",
     },
   },
-  overrides: [
-    // disable restricted imports in tw-components
-    {
-      files: "src/tw-components/**/*",
-      rules: {
-        "no-restricted-imports": ["off"],
-      },
-    },
-    // allow direct PostHog imports inside analytics helpers
-    {
-      files: "src/@/analytics/**/*",
-      rules: {
-        "no-restricted-imports": ["off"],
-      },
-    },
-    // enable rule specifically for TypeScript files
-    {
-      files: ["*.ts", "*.tsx"],
-      rules: {
-        "@typescript-eslint/explicit-module-boundary-types": ["off"],
-      },
-    },
-
-    // in test files, allow null assertions and anys and eslint is sometimes weird about the react-scope thing
-    {
-      files: ["*test.ts?(x)"],
-      rules: {
-        "@typescript-eslint/no-non-null-assertion": "off",
-        "@typescript-eslint/no-explicit-any": "off",
-
-        "react/display-name": "off",
-      },
-    },
-    // allow requires in non-transpiled JS files and logical key ordering in config files
-    {
-      files: [
-        "babel-node.js",
-        "*babel.config.js",
-        "env.config.js",
-        "next.config.js",
-        "webpack.config.js",
-        "packages/mobile-web/package-builder/**",
-      ],
-      rules: {},
-    },
-
-    // setupTests can have separated imports for logical grouping
-    {
-      files: ["setupTests.ts"],
-      rules: {
-        "import/newline-after-import": "off",
-      },
-    },
-    // THIS NEEDS TO GO LAST!
-    {
-      files: ["*.ts", "*.js", "*.tsx", "*.jsx"],
-      extends: ["biome"],
-    },
-  ],
-  env: {
-    browser: true,
-    node: true,
-  },
 };

apps/dashboard/biome.json

@@ -1,16 +1,4 @@
 {
-  "$schema": "https://biomejs.dev/schemas/1.9.2/schema.json",
-  "extends": ["../../biome.json"],
-  "overrides": [
-    {
-      "include": ["src/css/swagger-ui.css"],
-      "linter": {
-        "rules": {
-          "suspicious": {
-            "noImportantInKeyframe": "off"
-          }
-        }
-      }
-    }
-  ]
+  "$schema": "https://biomejs.dev/schemas/2.0.0/schema.json",
+  "extends": "//"
 }