From e4835a260796c0c7cb1c8dc5f5a24bf057938baa Mon Sep 17 00:00:00 2001
From: marcosvega91 <marcomoretti0103@gmail.com>
Date: Wed, 24 Jun 2020 19:14:39 +0200
Subject: [PATCH 1/2] test: add failing test

---
 src/lib/queryAdvise.test.js | 54 ++++++++++++++++++++++---------------
 tests/test-utils.js         | 19 +++++++++++++
 2 files changed, 51 insertions(+), 22 deletions(-)
 create mode 100644 tests/test-utils.js

diff --git a/src/lib/queryAdvise.test.js b/src/lib/queryAdvise.test.js
index 993832e0..94a85992 100644
--- a/src/lib/queryAdvise.test.js
+++ b/src/lib/queryAdvise.test.js
@@ -1,5 +1,5 @@
 import { getQueryAdvise, getAllPossibileQueries } from './queryAdvise';
-
+import { render } from '../../tests/test-utils';
 const emptyObject = `
   Object {
     "data": Object {},
@@ -43,16 +43,27 @@ it('should return an empty object if element node is a malformed object', () =>
 });
 
 it('should add `screen.` on suggested query returned by getSuggestedQuery', () => {
-  const rootNode = document.createElement('div');
-  const element = document.createElement('button');
-  const result = getQueryAdvise({ rootNode, element });
+  const { container } = render(`<button />`);
+  const element = container.querySelector('button');
+  const result = getQueryAdvise({ rootNode: container, element });
   expect(result.suggestion.expression).toStartWith('screen.');
 });
 
+it('should not throw error if something is wrong in @testing-library/dom', () => {
+  const { container } = render(`
+  <div id="a">One</div>
+  <div id="b">Two</div>
+  <input
+    type="text"
+    aria-labelledby="a b"
+  />`);
+  const input = container.querySelector('input');
+  expect(() => getAllPossibileQueries(input)).not.toThrow();
+});
+
 it('[getAllPossibileQueries] should return an object with all possibile queries', () => {
-  const rootNode = document.createElement('div');
-  const element = document.createElement('button');
-  rootNode.appendChild(element);
+  const { container, rerender } = render(`<button />`);
+  const element = container.firstChild;
   let suggestedQueries = getAllPossibileQueries(element);
 
   expect(suggestedQueries).toMatchInlineSnapshot(`
@@ -68,21 +79,20 @@ it('[getAllPossibileQueries] should return an object with all possibile queries'
       },
     }
   `);
-
-  rootNode.innerHTML = `
-    <label for="username">Username</label>
-    <input 
-      id="username"
-      name="username"
-      placeholder="how should I call you?" 
-      data-testid="uname"
-      title="enter your username"
-      alt="enter your username"
-      value="john-doe"
-      type="text"
-    />
-  `;
-  const input = rootNode.querySelector('input');
+  rerender(`
+  <label for="username">Username</label>
+  <input 
+    id="username"
+    name="username"
+    placeholder="how should I call you?" 
+    data-testid="uname"
+    title="enter your username"
+    alt="enter your username"
+    value="john-doe"
+    type="text"
+  />
+`);
+  const input = container.querySelector('input');
   suggestedQueries = getAllPossibileQueries(input);
 
   expect(suggestedQueries).toMatchInlineSnapshot(`
diff --git a/tests/test-utils.js b/tests/test-utils.js
new file mode 100644
index 00000000..f57cd170
--- /dev/null
+++ b/tests/test-utils.js
@@ -0,0 +1,19 @@
+function render(html, { container = document.createElement('div') } = {}) {
+  container.innerHTML = html;
+  function rerender(newHtml) {
+    return render(newHtml, { container });
+  }
+  return { container, rerender };
+}
+
+function renderIntoDocument(html) {
+  return render(html, { container: document.body });
+}
+
+function cleanup() {
+  document.body.innerHTML = '';
+}
+
+afterEach(cleanup);
+
+export { render, renderIntoDocument, cleanup };

From 4e6ed145973844b887232ccc242d64ef27e65323 Mon Sep 17 00:00:00 2001
From: marcosvega91 <marcomoretti0103@gmail.com>
Date: Wed, 24 Jun 2020 19:14:55 +0200
Subject: [PATCH 2/2] fix: do not throw if getSuggestedQuery is thrown

fix #214
---
 src/lib/queryAdvise.js | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/lib/queryAdvise.js b/src/lib/queryAdvise.js
index 820c8783..4d107381 100644
--- a/src/lib/queryAdvise.js
+++ b/src/lib/queryAdvise.js
@@ -111,7 +111,11 @@ export function getAllPossibileQueries(element) {
     .filter((query) => query.type !== 'GENERIC')
     .map((query) => {
       const method = getFieldName(query.method);
-      return getSuggestedQuery(element, 'get', method);
+      try {
+        return getSuggestedQuery(element, 'get', method);
+      } catch (e) {
+        return undefined;
+      }
     })
     .filter((suggestedQuery) => suggestedQuery !== undefined)
     .reduce((obj, suggestedQuery) => {