feat(byRole): add documentation for new option (aria-current) of ByRole queries #822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- docs for PR: testing-library/dom-testing-library#943 - according to issue: testing-library/dom-testing-library#864
4 tasks
nickserv
reviewed
Jul 12, 2021
docs/queries/byrole.mdx
Outdated
| `true`, `false` | ||
|
|
||
| You can filter the returned elements by their current status by setting | ||
| `current: true` (for any valid value) or `current: false` (for false). |
Member
There was a problem hiding this comment.
Are we changing this to support any aria-current value as @eps1lon suggested?
Member
|
@all-contributors add @savcni01 for docs |
Contributor
|
I've put up a pull request to add @savcni01! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds documentation for feature added at: testing-library/dom-testing-library#943
The feature added according to:
testing-library/dom-testing-library#864